-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make supernodal a configurable CMake option #659
Conversation
@jjwilke 's configuration:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on cmake updates, will wait for @iyamazaki to confirm he can compile and run the code using CMake build system before merging.
@@ -0,0 +1,20 @@ | |||
function(kokkoskernels_feature_depends_on_tpls FEATURE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, will be very useful!
@jjwilke this is failing during configuration in spot-check tests on kokkos-dev-2, I think sample message:
|
87e0e3b
to
18ea3e7
Compare
@ndellingwood You are correct. Fixed. |
kokkos-dev-2 spot-check passes
tpl spot-check failed in a couple builds due to #657, fix was merged after this PR was created |
No description provided.