Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GCC MKL builds: Issue #480 #653

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Add support for GCC MKL builds: Issue #480 #653

merged 1 commit into from
Mar 13, 2020

Conversation

jjwilke
Copy link
Contributor

@jjwilke jjwilke commented Mar 11, 2020

No description provided.

@jjwilke jjwilke added this to the 3.1 Release milestone Mar 11, 2020
@ndellingwood
Copy link
Contributor

Passes tpl spot-checks

Running on machine: kokkos-dev-2
KokkosKernels Repository Status:  c49f74b2b7f2918bc15d543be1c37432984000bd Merge branch 'develop' into pr-653

Kokkos Repository Status:  9e45ca5fbbebd388fb28cc80019e7be2b4ddfe0c Merge pull request #2864 from ndellingwood/issue-2863


Going to test compilers:  gcc/7.3.0 gcc/8.3.0 gcc/9.1 intel/18.0.5 clang/8.0 cuda/10.1
Testing compiler gcc/7.3.0
  Starting job gcc-7.3.0-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-7.3.0-OpenMP-release
Testing compiler gcc/8.3.0
  Starting job gcc-7.3.0-Pthread-release
kokkos options: 
kokkos devices: Pthread
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-7.3.0-Pthread-release
Testing compiler gcc/9.1
  Starting job gcc-8.3.0-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-8.3.0-Serial-release
  Starting job gcc-9.1-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-9.1-OpenMP-release
Testing compiler intel/18.0.5
  Starting job gcc-9.1-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-9.1-Serial-release
Testing compiler clang/8.0
  Starting job intel-18.0.5-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-18.0.5-OpenMP-release
  Starting job clang-8.0-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized -Wno-pass-failed 
  PASSED clang-8.0-Cuda_OpenMP-release
Testing compiler cuda/10.1
  Starting job clang-8.0-Pthread_Serial-release
kokkos options: 
kokkos devices: Pthread,Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized -Wno-pass-failed 
  PASSED clang-8.0-Pthread_Serial-release
  Starting job cuda-10.1-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED cuda-10.1-Cuda_OpenMP-release
#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=120 run_time=171
clang-8.0-Pthread_Serial-release build_time=50 run_time=154
cuda-10.1-Cuda_OpenMP-release build_time=170 run_time=152
gcc-7.3.0-OpenMP-release build_time=45 run_time=65
gcc-7.3.0-Pthread-release build_time=41 run_time=77
gcc-8.3.0-Serial-release build_time=41 run_time=74
gcc-9.1-OpenMP-release build_time=52 run_time=65
gcc-9.1-Serial-release build_time=46 run_time=73
intel-18.0.5-OpenMP-release build_time=148 run_time=38

Running on machine: kokkos-dev
KokkosKernels Repository Status:  c70dd095913ded7da37d37b28063921dac7424c9 Merge branch 'develop' into pr-653

Kokkos Repository Status:  9e45ca5fbbebd388fb28cc80019e7be2b4ddfe0c Merge pull request #2864 from ndellingwood/issue-2863


Going to test compilers:  gcc/5.3.0 gcc/7.3.0 intel/17.0.1 clang/4.0.1 clang/7.0.1 cuda/9.2
Testing compiler gcc/5.3.0
Testing compiler gcc/7.3.0
  Starting job gcc-5.3.0-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-5.3.0-OpenMP-release
Testing compiler intel/17.0.1
  Starting job gcc-7.3.0-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-7.3.0-Serial-release
Testing compiler clang/4.0.1
  Starting job intel-17.0.1-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-17.0.1-OpenMP-release
Testing compiler clang/7.0.1
  Starting job clang-4.0.1-Pthread_Serial-release
kokkos options: 
kokkos devices: Pthread,Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED clang-4.0.1-Pthread_Serial-release
Testing compiler cuda/9.2
  Starting job clang-7.0.1-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED clang-7.0.1-Cuda_OpenMP-release
  Starting job cuda-9.2-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED cuda-9.2-Cuda_OpenMP-release
#######################################################
PASSED TESTS
#######################################################
clang-4.0.1-Pthread_Serial-release build_time=200 run_time=293
clang-7.0.1-Cuda_OpenMP-release build_time=585 run_time=646
cuda-9.2-Cuda_OpenMP-release build_time=693 run_time=349
gcc-5.3.0-OpenMP-release build_time=111 run_time=148
gcc-7.3.0-Serial-release build_time=141 run_time=137
intel-17.0.1-OpenMP-release build_time=203 run_time=76

ndellingwood
ndellingwood reviewed Mar 13, 2020
View reviewed changes
cmake/Modules/FindTPLMKL.cmake
MESSAGE(FATAL_ERROR "No support currently for MKL without using the Intel compiler")
IF (NOT DEFINED ENV{MKLROOT})
SET(NO_MKL_ROOT_GIVEN "MKL-NOTFOUND")
MESSAGE(WARNING "No MKLROOT environment variable specified - must source mklvars.sh to configure MKL path")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjwilke what is mklvars.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MKL installation comes with an mklvars.sh that you should source to configure your environment. It's really the only robust way to make sure all the libraries can be found for non-Intel compilers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from the MKL installation, not Kokkos Kernels - in case that wasn't clear. I can change the verbage if that was confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to change it, thanks for clarifying.

@ndellingwood ndellingwood merged commit 25d5b1c into kokkos:develop Mar 13, 2020
@kokkos-devops-admin kokkos-devops-admin mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndellingwood ndellingwood ndellingwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jjwilke @ndellingwood