Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup installation/build of parent project builds #628

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

jjwilke
Copy link
Contributor

@jjwilke jjwilke commented Mar 2, 2020

No description provided.

@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 2, 2020

Related to #621

@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 2, 2020

This needs to be cleaned up in Kokkos as well.

@kuberry
Copy link
Contributor

kuberry commented Mar 2, 2020

Looks good. I just built and installed using this and was able to link against the product. I closed PR #621 as a result.

Thanks @jjwilke

@jjwilke jjwilke added this to the 3.1 Release milestone Mar 10, 2020
@ndellingwood
Copy link
Contributor

Due diligence spot-check results:

Running on machine: kokkos-dev-2
Repository Status:  d6a225df6fe186dcadfceabf1241bfe254ee7b1c cleanup installation/build of parent project builds


Going to test compilers:  gcc/7.3.0 gcc/8.3.0 gcc/9.1 intel/18.0.5 clang/8.0 cuda/10.1
Testing compiler gcc/7.3.0
  Starting job gcc-7.3.0-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-7.3.0-OpenMP-release
Testing compiler gcc/8.3.0
  Starting job gcc-7.3.0-Pthread-release
kokkos options: 
kokkos devices: Pthread
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-7.3.0-Pthread-release
Testing compiler gcc/9.1
  Starting job gcc-8.3.0-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-8.3.0-Serial-release
  Starting job gcc-9.1-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-9.1-OpenMP-release
Testing compiler intel/18.0.5
  Starting job gcc-9.1-Serial-release
kokkos options: 
kokkos devices: Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
  PASSED gcc-9.1-Serial-release
Testing compiler clang/8.0
  Starting job intel-18.0.5-OpenMP-release
kokkos options: 
kokkos devices: OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED intel-18.0.5-OpenMP-release
  Starting job clang-8.0-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized -Wno-pass-failed 
  PASSED clang-8.0-Cuda_OpenMP-release
Testing compiler cuda/10.1
  Starting job clang-8.0-Pthread_Serial-release
kokkos options: 
kokkos devices: Pthread,Serial
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized -Wno-pass-failed 
  PASSED clang-8.0-Pthread_Serial-release
  Starting job cuda-10.1-Cuda_OpenMP-release
kokkos options: 
kokkos devices: Cuda,OpenMP
kokkos cxx: -O3 -Wall -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized 
  PASSED cuda-10.1-Cuda_OpenMP-release
#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=119 run_time=152
clang-8.0-Pthread_Serial-release build_time=50 run_time=150
cuda-10.1-Cuda_OpenMP-release build_time=156 run_time=141
gcc-7.3.0-OpenMP-release build_time=44 run_time=46
gcc-7.3.0-Pthread-release build_time=42 run_time=75
gcc-8.3.0-Serial-release build_time=41 run_time=70
gcc-9.1-OpenMP-release build_time=53 run_time=45
gcc-9.1-Serial-release build_time=46 run_time=72
intel-18.0.5-OpenMP-release build_time=150 run_time=45

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, passed spot-check and verified by Paul that it resolves his issue. @jjwilke drop in the "Ready to merge" board if merging this won't conflict with any other PRs

@ndellingwood
Copy link
Contributor

@jjwilke looks like a merge conflict due to my merge of PR #627 that added a missing alias, I'm assuming this PR is preferred?

@jjwilke jjwilke force-pushed the fix-parent-install branch from d6a225d to afb8f9a Compare March 12, 2020 18:28
@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 12, 2020

Oops. I opened this on a kokkos-kernels branch instead of my fork. I promise to never do that again.

@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 12, 2020

@ndellingwood I rebased and removed the conflict. This should be good.

@ndellingwood ndellingwood merged commit 1f89b17 into develop Mar 12, 2020
@ndellingwood ndellingwood deleted the fix-parent-install branch October 29, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants