Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched - team interface instantiation and testing on serial and openmp #62

Merged
merged 4 commits into from
Aug 31, 2017

Conversation

kyungjoo-kim
Copy link
Contributor

@ambrad

  1. Fix the "namespace Team"
  2. Add unit test for team interface (team size is auto)

@kyungjoo-kim kyungjoo-kim requested a review from ambrad August 31, 2017 01:04
@ambrad
Copy link
Contributor

ambrad commented Aug 31, 2017

@kyungjoo-kim, I'll look at this tomorrow.

@mhoemmen mhoemmen changed the title Batched - team interface instanciation and testing on serial and openmp Batched - team interface instantiation and testing on serial and openmp Aug 31, 2017
@kyungjoo-kim
Copy link
Contributor Author

Please hold this a bit. I just figured out how to test sandia machines using kokkoskernels script. I already see some warning error.

Copy link
Contributor

@ambrad ambrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyungjoo-kim, am I correct that this patch does these 3 things: (i) rationalize namespace and struct names, (ii) reformat code extensively (the primary cause of the large patch?), (iii) add unit tests? If (ii) is correct, then I understand why this commit is so large. If not, I want to understand better what has changed.

I brought these changes into Trilinos and tested with BlockTriDiContainer on CPU and P100, and all is well.

@kyungjoo-kim
Copy link
Contributor Author

kyungjoo-kim commented Aug 31, 2017

@ambrad
(i) yes right
(ii) yes it reformats some type names
(iii) adding unit tests for team
(iv) also remove all warning when I compile it with cuda.

@crtrott
I also fix some pointless warnings 085d574. related to #65

@crtrott crtrott merged commit f2c730c into develop Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants