-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full MatrixMarket support for read_mtx() #466
Conversation
- read_mtx now supports pattern, complex, array, Hermitian, symmetric, and skew-symmetric (the full MatrixMarket specification). Before, it just supported "matrix coordinate real general". - support Kokkos::complex scalar type in write_graph_mtx() - support non-host accessible views in write_kokkos_crst_matrix, by getting a host mirror
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian-kelley : Thanks for fixing this quickly. One comment, see below.
Thanks, @brian-kelley : We can merge if spot check passes. |
@srajama1 Running them now. |
@srajama1 It's a good thing I ran the spot check because there was a build error. But it works now :) kokkos-dev spot-check: White spot-check: |
I assume bowman is fine as well ? |
@srajama1 Yes: |
@brian-kelley Thanks a lot ! Merging it. |
@srajama1 Thanks! Bowman takes way longer than the other two so I get impatient and post them first :) |
Thank @brian-kelley, understood ! I hope I am not annoying you by asking for these in multiple PRs. We have to move to an automated PR testing next year and hopefully that will resolve this. |
and skew-symmetric (the full MatrixMarket specification). Before, it just
supported "matrix coordinate real general".
getting a host mirror
There are no tests that use the matrix IO, so the spot check doesn't help evaluate these changes. However, once we migrate to CMake for testing, a "copy files to binary dir" will make it easy to test each possible format/field/symmetry combination for read_mtx.
For now, I tested the I/O manually by running the following matrices from the SuiteSparse collection through the SPGEMM testing driver: