SpMV_struct: Implementation of a structured spmv algorithm #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation hinges on the regularity of the sparsity pattern of the matrix. It is leveraged to access vector entries without using the view of column indices. The new kernel is faster for the 5 stencils implemented: 1D, 2D and 3D FD and FE. It also does check for a multivector containing a single vector in which case it calls the vector implementation of spmv_struct. A fall back to the unstructured implementation is used for the multivector case at the moment. A unit test and a performance test are added to assess correctness and performance of the kernel. Three utility functions are implemented in: test_common/KokkosKernels_Test_Structured_Matrix.hpp They return matrices corresponding to the discretization of the Laplace operator on 1D, 2D and 3D grids for FD and FE discretization. Reactivating the spmv unit-test on Cuda
Closed
|
@lucbv Thanks ! Let me take a look. |
|
So, results on bowman: |
|
Results on white: |
srajama1
approved these changes
Jul 23, 2019
|
@brian-kelley Spot checks passed here, why would it fail now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation hinges on the regularity of the sparsity pattern of the matrix.
It is leveraged to access vector entries without using the view of column indices.
The new kernel is faster for the 5 stencils implemented: 1D, 2D and 3D FD and FE.
It also does check for a multivector containing a single vector in which case it
calls the vector implementation of spmv_struct. A fall back to the unstructured
implementation is used for the multivector case at the moment.
A unit test and a performance test are added to assess correctness and performance
of the kernel. Three utility functions are implemented in:
test_common/KokkosKernels_Test_Structured_Matrix.hpp
They return matrices corresponding to the discretization of the Laplace operator on
1D, 2D and 3D grids for FD and FE discretization.
Reactivating the spmv unit-test on Cuda