Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the HPX backend that was merged to Kokkos develop (kokkos/kokkos#1975).
I've had to do the same exercise of adding
fence
s to make sure the asynchronous version runs correctly. E.g.dot
has one version which returns the result and fences, and another which uses an out parameter and doesn't fence. These look pretty well defined (in terms of what blocks and what not) but would be good if you could confirm that the fences are actually where they should be.There are some which fail consistently even with the OpenMP backend, and I haven't attempted to fix them (I couldn't find issues for them. Will open some if needed.). Let me know if these are known issues and if I can ignore them.
These
all fail with something in the style of:
i.e. close but not quite.
reciprocal_int
fails with a division by zero.