Remove experimental namespace in batched functors. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyungjoo-kim
requested review from
crtrott and
ndellingwood
and removed request for
crtrott
|
@ndellingwood If I were you, I would not try to precisely examine this PR as it was a simple sed script work even thought it change 138 files. I tested spotcheck on white and it passes with the version of today kokkos. Could you merge this PR ? |
srajama1
approved these changes
Apr 8, 2019
|
it has a temporal promotion macro that distinguish kokkos::batched from kokkos::batched::experimental. so it is safe with trilinos. |
|
@kyungjoo-kim : Thanks, merging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove experimental namespace from kokkosbatched functors. #371