spgemm unit test: update cusparse macro check #294
Conversation
Similar fix as in PR kokkos#290 for MKL
|
@kyungjoo-kim @srajama1 |
| @@ -301,7 +301,7 @@ void test_spgemm(lno_t numRows, size_type nnz, lno_t bandwidth, lno_t row_size_v | |||
| case SPGEMM_CUSPARSE: | |||
| //TODO: add these test failure cases for cusparse too. | |||
| algo = "SPGEMM_CUSPARSE"; | |||
| #ifndef KERNELS_HAVE_CUSPARSE | |||
| #if !defined(KERNELS_HAVE_CUSPARSE) && !defined(KOKKOSKERNELS_ENABLE_TPL_CUSPARSE) | |||
There was a problem hiding this comment.
Did we check this modification pass the test in kokkoskernels with cusparse enabled ?
There was a problem hiding this comment.
Not yet, trying to get the Trilinos build on White going.
Are there extra settings to use cusparse like with mkl? For example, adding an extra cxxflag, setting an a path variable, etc? I haven't built kokkos-kernels with cusparse before
There was a problem hiding this comment.
I am not sure. One problematic thing is that "cmake configure" may not match to "make configure". We have two build systems and cmake configure is not tested nor updated in the kokkoskernels level. cusparse or cublas should be ON by default when you test on cuda machines; however, it is possible that some macro variables may not set correctly. Let's wait until your test on white is done.
Pattern match trilinos/Trilinos#3458 to disable test until issues resolved.
|
Please revert after the original issue is fixed. |
|
Related to issue #296 |
Similar fix as in PR #290 for MKL