CI: address sanitizer and most of undefined sanitizer
#2408
Conversation
Exclude vptr due to Preconditioner visibility. Exclude signed integer overflow because we do this all over the place. Signed-off-by: Carl Pearson <cwpears@sandia.gov>
cwpearson
force-pushed
the
ci/sanitizers
branch
from
453dc06 to
79e7d09
Compare
There was a problem hiding this comment.
Thanks for working on getting this cleaned up and ready to run @cwpearson , I think only an update to the name is needed. Added tentative approval so the PR is not blocked on approval
|
This will need the AT2-SPECIAL-APPROVAL tag when ready to test (post-merge of #2407) |
| strategy: | ||
| matrix: | ||
| include: | ||
| - backend: "SERIAL" |
There was a problem hiding this comment.
Do we plan to expand this further? Otherwise maybe the matrix part can be removed and the variable associated with it can be hard coded directly in the configuration options?
There was a problem hiding this comment.
Maybe a similar build just with clang instead? I think they have different implementations but the same interface of these sanitizers.
|
We do not really need to set the special approval here as we do not really need to run the AT2 CI, I can merge when ready. |
This is not a permanent fix, we probably need to set this build on a different platform but should be enough to get one set of results and observe how good/bad we are doing... Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
Signed-off-by: Carl Pearson <cwpears@sandia.gov>
cwpearson
force-pushed
the
ci/sanitizers
branch
from
6b9684c to
718e823
Compare
|
I signed off on all the commits |
cwpearson
force-pushed
the
ci/sanitizers
branch
from
2a2b64f to
718e823
Compare
Exclude vptr due to Preconditioner visibility.
Exclude signed integer overflow because we do this all over the place (future work?)
Needs #2407 before it will pass.