Mult result conversion #2405
Merged
Mult result conversion #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids potential overflow when low precision data is multiplied and then store in higher precision variable: size_t = int * int Focusing on issues in the library for now, unit-tests will be fixed later. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
lucbv
force-pushed
the
mult_result_conversion
branch
from
5663b8f to
0f94c1b
Compare
cwpearson
approved these changes
Oct 29, 2024
After discussion in the PR, these changes should not result in issues when passed to the view constructors and improve clarity for future maintenance. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
cwpearson
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.