-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guard for cusparse spmv_mv_tpl_spec_avail #2176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issue kokkos#2175 Configuring with magma tpl enabled and cusparse disabled mistakenly triggers the cusparse tpl avail check to be true Guard the KOKKOSSPARSE_SPMV_MV_TPL_SPEC_AVAIL_CUSPARSE macros when CUSPARSE is enabled to prevent this
brian-kelley
approved these changes
Apr 12, 2024
Testing info with magma, using a local install (not covered by CI): Reproducer configuration (weaver) source /etc/profile.d/modules.sh
source /projects/ppc64le-pwr9-rhel8/legacy-env.sh
module purge
module load cuda/11.2.2/gcc/8.3.1 cmake/3.23.1 openblas/0.3.18/gcc/8.3.1
../../cm_generate_makefile.bash --with-cuda --compiler=$HOME/kokkos/bin/nvcc_wrapper --arch=Volta70 --with-tpls=magma Test output:
|
ndellingwood
added a commit
to ndellingwood/Trilinos
that referenced
this pull request
Apr 12, 2024
Patch created from kokkos/kokkos-kernels#2176 Add guard for cusparse spmv_mv_tpl_spec_avail Addresses linker errors for builds with magma enabled and cusparse disabled
ndellingwood
added
the
TrilinosPatchMatch
Apply this label for PR's mirroring changes submitted directly to Trilinos
label
Apr 12, 2024
ndellingwood
added a commit
to ndellingwood/Trilinos
that referenced
this pull request
Apr 18, 2024
Resolve issues with Magma and Cuda singleton multiple definitions Reported in kokkos/kokkos-kernels#2175 Patch generated from kokkos/kokkos-kernels#2176
ndellingwood
added a commit
that referenced
this pull request
May 1, 2024
Add guard for cusparse spmv_mv_tpl_spec_avail (cherry picked from commit cb824ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
TrilinosPatchMatch
Apply this label for PR's mirroring changes submitted directly to Trilinos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #2175
Configuring with magma tpl enabled and cusparse disabled mistakenly triggers the cusparse tpl avail check to be true Guard the KOKKOSSPARSE_SPMV_MV_TPL_SPEC_AVAIL_CUSPARSE macros when CUSPARSE is enabled to prevent this