Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signed/unsigned comparison warning #2150

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix signed/unsigned comparison warning #2150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sparse/impl/KokkosSparse_spmv_bsrmatrix_spec.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ struct SPMV_MV_BSRMATRIX<ExecutionSpace, Handle, AMatrix, XVector, YVector,
const YScalar &beta, const YVector &Y) {
static_assert(std::is_integral_v<typename AMatrix::non_const_value_type>,
"This implementation is only for integer Scalar types.");
for (typename AMatrix::non_const_size_type j = 0; j < X.extent(1); ++j) {
for (size_t j = 0; j < X.extent(1); ++j) {
const auto x_j = Kokkos::subview(X, Kokkos::ALL(), j);
auto y_j = Kokkos::subview(Y, Kokkos::ALL(), j);
typedef SPMV_BSRMATRIX<ExecutionSpace, Handle, AMatrix, decltype(x_j),
Expand Down
2 changes: 1 addition & 1 deletion sparse/impl/KokkosSparse_spmv_spec.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ struct SPMV_MV<ExecutionSpace, Handle, AMatrix, XVector, YVector, true, false,
static_assert(std::is_integral_v<typename AMatrix::non_const_value_type>,
"This implementation is only for integer Scalar types.");
KokkosKernels::Experimental::Controls defaultControls;
for (typename AMatrix::non_const_size_type j = 0; j < x.extent(1); ++j) {
for (size_t j = 0; j < x.extent(1); ++j) {
auto x_j = Kokkos::subview(x, Kokkos::ALL(), j);
auto y_j = Kokkos::subview(y, Kokkos::ALL(), j);
typedef SPMV<ExecutionSpace, Handle, AMatrix, decltype(x_j),
Expand Down