Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for missing STL inclusion #2113

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Fix for missing STL inclusion #2113

merged 1 commit into from
Feb 17, 2024

Conversation

seanofthemillers
Copy link
Contributor

When building with

KokkosKernels_ENABLE_EXPERIMENTAL=ON

I'm finding that this file is missing an include statement.

@seanofthemillers seanofthemillers mentioned this pull request Feb 16, 2024
Merged
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

ndellingwood
ndellingwood approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we had this cmake option. Thanks for the fix!

@ndellingwood ndellingwood added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 16, 2024
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 16, 2024
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@ndellingwood ndellingwood added AT: PRE-TEST INSPECTED Mark this PR as approved for testing. TrilinosPatchMatch Apply this label for PR's mirroring changes submitted directly to Trilinos labels Feb 16, 2024
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 1191
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

  • Build Num: 778
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GNU1021

  • Build Num: 449
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight

  • Build Num: 436
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GNU1021

  • Build Num: 437
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo

  • Build Num: 441
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001_solo

  • Build Num: 413
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 923
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 918
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA90A_ROCM560

  • Build Num: 911
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA90A_Tpls_ROCM560

  • Build Num: 431
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (seanofthemillers/kokkos-kernels)
  • Branch: fix_missing_inclusion_bsrmatrix
  • SHA: e3026de
  • Mode: TEST_REPO

Pull Request Author: seanofthemillers

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 1191
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

  • Build Num: 778
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GNU1021

  • Build Num: 449
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight

  • Build Num: 436
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GNU1021

  • Build Num: 437
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo

  • Build Num: 441
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001_solo

  • Build Num: 413
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 923
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 918
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA90A_ROCM560

  • Build Num: 911
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA90A_Tpls_ROCM560

  • Build Num: 431
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_REPO https://github.com/seanofthemillers/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e3026de
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8ecbcb7
PR_LABELS AT: PRE-TEST INSPECTED;TrilinosPatchMatch
PULLREQUESTNUM 2113
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@ndellingwood ndellingwood merged commit 39bad0e into kokkos:develop Feb 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndellingwood ndellingwood ndellingwood approved these changes

Assignees
No one assigned
Labels
AT: PRE-TEST INSPECTED Mark this PR as approved for testing. TrilinosPatchMatch Apply this label for PR's mirroring changes submitted directly to Trilinos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanofthemillers @kokkos-devops-admin @ndellingwood