Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapack magma tpl fixes #2044

Merged

Conversation

ndellingwood
Copy link
Contributor

Fixes for 4.2.00, apply to patch release 4.2.01
See issue #2042

Fixes for 4.2.00
See issue kokkos#2042
@ndellingwood
Copy link
Contributor Author

Trilinos patch trilinos/Trilinos#12555

@ndellingwood
Copy link
Contributor Author

Fails look like they're due to searching for release-candidate-4.2.01 branch of Kokkos (not created yet)

@ndellingwood ndellingwood requested a review from vqd8a November 22, 2023 21:07
@ndellingwood
Copy link
Contributor Author

These are the test results from Weaver (cuda/11.2, magma-2.7.2):

bash-4.4$ ./lapack/unit_test/KokkosKernels_lapack_cuda 
[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from Cuda
[ RUN      ] Cuda.gesv_double
[       OK ] Cuda.gesv_double (7740 ms)
[ RUN      ] Cuda.gesv_mrhs_double
[       OK ] Cuda.gesv_mrhs_double (350 ms)
[ RUN      ] Cuda.trtri_double
[       OK ] Cuda.trtri_double (462 ms)
[----------] 3 tests from Cuda (8552 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test case ran. (8552 ms total)
[  PASSED  ] 3 tests.

@ndellingwood
Copy link
Contributor Author

None of these changes will be hit by CI. Local testing confirms fix for magma (posted above). Going ahead with merge to release-candidate-4.2.01

@ndellingwood ndellingwood merged commit 940cfbe into kokkos:release-candidate-4.2.01 Nov 22, 2023
1 of 5 checks passed
@vqd8a
Copy link
Contributor

vqd8a commented Nov 23, 2023

@ndellingwood Thanks for doing this.

@ndellingwood ndellingwood deleted the magma-fix-4200 branch February 13, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants