Experimental hip cleanup #1999
Merged
Experimental hip cleanup #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-kelley
approved these changes
Oct 17, 2023
ndellingwood
approved these changes
Oct 17, 2023
|
@lucbv this would be nice cleanup to have with 4.2 if possible, thanks for working on this :) |
cwpearson
approved these changes
Oct 18, 2023
| #cmakedefine KOKKOSKERNELS_INST_EXECSPACE_HIP | ||
| #cmakedefine KOKKOSKERNELS_INST_MEMSPACE_HIPSPACE | ||
| /* Whether to build kernels for execution space Kokkos::Experimental::SYCL */ | ||
| #cmakedefine KOKKOSKERNELS_INST_EXECSPACE_SYCL | ||
| #cmakedefine KOKKOSKERNELS_INST_MEMSPACE_SYCLSPACE | ||
| #cmakedefine KOKKOSKERNELS_INST_MEMSPACE_SYCLSHAREDSPACE | ||
| /* Whether to build kernels for execution space Kokkos::Experimental::HIP */ | ||
| /* Whether to build kernels for execution space Kokkos::Experimental::OpenMPTarget */ |
|
Removing AT:WIP since solo is back, hopefully this won't have much trouble with the auto-tester! |
Just reflecting the move of HIP and HIPSpace out of experimental so that we do not get deprecation warning and even failures down the road. This was really done in Kokkos Core 4.0.0 so it is time to catch up...
lucbv
force-pushed
the
experimental_hip_cleanup
branch
from
5f30552 to
1537c4f
Compare
|
Rebased on develop, the osx build should be happier now! |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA90A_ROCM560
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA90A_Tpls_ROCM560
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA90A_ROCM560
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA90A_Tpls_ROCM560
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ndellingwood cwpearson ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
ndellingwood
pushed a commit
that referenced
this pull request
Oct 19, 2023
Experimental hip cleanup (cherry picked from commit d9a67b9)
|
Cherry-picked to release-candidate-4.2.00 SHA 06b314c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's a bit the PR of shame since we should really have done that when Kokkos Core 4.0.0 came out in Jan/Feb this year...
Anyway, it really does not change code that much just reflects that fact that HIP was moved out of Experimental!
I almost want to mark this as
BlockPromotionbut that's not really the case?