Fix out-of-bounds and timeout with bounds checking #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for catching and fixing these @ibaned ! |
mndevec
previously approved these changes
Mar 26, 2018
based on feedback from trilinos/Trilinos#2452
|
@mndevec please don't merge yet, I have a slight change from @bartlettroscoe |
|
Okay, I just pushed that extra change. |
mndevec
approved these changes
Mar 26, 2018
This was referenced Mar 27, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the changes proposed in trilinos/Trilinos#2452 .
There was an off-by-one error when constructing subviews to supply as begin/end arrays. Also, the
dgemm_doubletest is very slow with bounds checking on, so until it is modified such that it runs faster, I've added code to disable it when bounds checking is on.