Fix for rocblas builds

[ndellingwood]

• Rename uploChar to uplo in fillMode for consistency with usage
• Dereference uplo in fillMode usage for comparison to char

[ndellingwood]

Minor changes to resolve compilation errors in nightly rocm + tpls build:

05:16:01 /home/jenkins/caraway-new/workspace/KokkosKernels_CarawayMI100_Rocm520_HipSerial_RocBlas_RocSparse/kokkos-kernels/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp:273:1: error: use of undeclared identifier 'uploChar'
05:16:01 KOKKOSBLAS2_DSYR_ROCBLAS(Kokkos::LayoutLeft, Kokkos::HIP, Kokkos::HIPSpace,
05:16:01 ^
05:16:01 /home/jenkins/caraway-new/workspace/KokkosKernels_CarawayMI100_Rocm520_HipSerial_RocBlas_RocSparse/kokkos-kernels/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp:61:7: note: expanded from macro 'KOKKOSBLAS2_DSYR_ROCBLAS'
05:16:01       KOKKOSBLAS2_SYR_ROCBLAS_DETERMINE_ARGS(LAYOUT);                       \
05:16:01       ^
05:16:01 /home/jenkins/caraway-new/workspace/KokkosKernels_CarawayMI100_Rocm520_HipSerial_RocBlas_RocSparse/kokkos-kernels/blas/tpls/KokkosBlas2_syr_tpl_spec_decl_rocblas.hpp:31:28: note: expanded from macro 'KOKKOSBLAS2_SYR_ROCBLAS_DETERMINE_ARGS'
05:16:01   rocblas_fill fillMode = (uploChar == 'L' || uploChar == 'l')  

Tested on Caraway to confirm this resolve compilation error with configuration:

salloc -N 1 -p MI100
module load cmake/3.19.3 rocm/5.2.0

$KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-devices=Hip,Serial --arch=VEGA908 --compiler=hipcc --cxxflags="-O3  " --cxxstandard="17" --with-hip --kokkos-path=$KOKKOS_PATH --kokkoskernels-path=$KOKKOSKERNELS_PATH --with-scalars='double,complex_double' --with-ordinals=int --with-offsets=int,size_t --with-layouts=LayoutLeft --with-tpls=rocblas,rocsparse

[e10harvey]

@cwpearson: Has KokkosKernels_PullRequest_VEGA908_Tpls_ROCM520 been passing for a week? If so, can you please open a change request to enable it in the AutoTester?

[kokkos-devops-admin]

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

[kokkos-devops-admin]

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

• Build Num: 698
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

• Build Num: 289
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

• Build Num: 312
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

• Build Num: 582
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

• Build Num: 543
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

• Build Num: 632
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

• Build Num: 685
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

• Build Num: 486
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

• Build Num: 481
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

• Build Num: 481
• Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (ndellingwood/kokkos-kernels)

• Branch: fix-rocblas
• SHA: f5e2f82
• Mode: TEST_REPO

Pull Request Author: ndellingwood

[kokkos-devops-admin]

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

• Build Num: 698
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

• Build Num: 289
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

• Build Num: 312
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

• Build Num: 582
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

• Build Num: 543
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

• Build Num: 632
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

• Build Num: 685
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

• Build Num: 486
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

• Build Num: 481
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

• Build Num: 481
• Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_REPO	https://github.com/ndellingwood/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	f5e2f82
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	6fdd658
PR_LABELS
PULLREQUESTNUM	1871
TEST_REPO_ALIAS	KOKKOSKERNELS

[kokkos-devops-admin]

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley e10harvey cwpearson ]!

[kokkos-devops-admin]

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge