Correcting 'syr test' bug causing compilation errors with Trilinos #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns of Kokkos and KK requesting CudaUVM)
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Using Repos:
Pull Request Author: eeprude |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
e10harvey
approved these changes
Jun 15, 2023
cwpearson
approved these changes
Jun 15, 2023
|
Yrvw! Thanks for sending important information that allowed me to replicate the issue.
Ernesto.
From: Nathan Ellingwood ***@***.***>
Date: Thursday, June 15, 2023 at 11:18 AM
To: kokkos/kokkos-kernels ***@***.***>
Cc: Prudencio, Ernesto Esteves ***@***.***>, Mention ***@***.***>
Subject: [EXTERNAL] Re: [kokkos/kokkos-kernels] Correcting 'syr test' bug causing compilation errors with Trilinos (PR #1870)
Cross-referencing #1869<#1869> , thanks for the fast fix @eeprude<https://github.com/eeprude> !
—
Reply to this email directly, view it on GitHub<#1870 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4RJTNSK2PZ7B77FAT26EUTXLM7XLANCNFSM6AAAAAAZHNS5CY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey cwpearson ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compilation error happens in kk syr unit tests, independent of any interactions with, or calls from, Trilinos.
I was able to replicate the problem at weaver with some of the information in the error email sent by Nathan. I think the key aspect causing the error was the presence of CudaUVM options in the configurations of Kokkos and kk. I will include those options in my own work from now on.
+- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
ssh weaver
bsub -Is -n 1 -q rhel8 -gpu num=1 bash
source /etc/profile.d/modules.sh
source /projects/ppc64le-pwr9-rhel8/legacy-env.sh
module load git
module load cmake/3.23.1
module load cuda/11.2.2/gcc/8.3.1
module load openblas/0.3.18/gcc/8.3.1
+- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
cmake
--install-prefix <BASE_PATH>/install/kokkos_git
-D CMAKE_BUILD_TYPE:STRING=Debug
-D CMAKE_CXX_STANDARD:STRING=17
-D CMAKE_CXX_FLAGS:STRING=""
-D CMAKE_CXX_EXTENSIONS:BOOL=OFF
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF
-D Kokkos_ENABLE_CUDA_LAMBDA=ON
-D Kokkos_ENABLE_SERIAL:BOOL=ON
-D Kokkos_ENABLE_OPENMP:BOOL=ON
-D Kokkos_ENABLE_THREADS:BOOL=OFF
-D Kokkos_ENABLE_DEPRECATED_CODE_3:BOOL=OFF
-D Kokkos_ENABLE_DEBUG_BOUNDS_CHECK:BOOL=ON
-D Kokkos_ENABLE_TESTS:BOOL=OFF
-D Kokkos_ENABLE_EXAMPLES:BOOL=OFF
-D Kokkos_ENABLE_CUDA=ON
-D Kokkos_ENABLE_CUDA_UVM=ON
-D Kokkos_ARCH_VOLTA70=ON
-D Kokkos_ARCH_POWER9=ON
~/work/Kokkos/kokkos
make -j16
make install
+- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
cmake
--install-prefix <BASE_PATH>/install/kokkos_kernels_syr_compbug
-D CMAKE_BUILD_TYPE:STRING=Debug
-D CMAKE_CXX_STANDARD:STRING=17
-D CMAKE_CXX_FLAGS:STRING="-Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized"
-D CMAKE_CXX_EXTENSIONS:BOOL=OFF
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF
-D Kokkos_ROOT:PATH="<BASE_PATH>/install/kokkos_git"
-D KokkosKernels_ENABLE_TPL_BLAS:BOOL=ON
-D KokkosKernels_ENABLE_TPL_CUBLAS:BOOL=ON
-D KokkosKernels_ENABLE_COMPONENT_BLAS=ON
-D KokkosKernels_ENABLE_COMPONENT_BATCHED=OFF
-D KokkosKernels_ENABLE_COMPONENT_GRAPH=OFF
-D KokkosKernels_ENABLE_COMPONENT_SPARSE=OFF
-D KokkosKernels_INST_INT:BOOL=ON
-D KokkosKernels_INST_FLOAT:BOOL=ON
-D KokkosKernels_INST_DOUBLE:BOOL=ON
-D KokkosKernels_INST_COMPLEX_FLOAT:BOOL=ON
-D KokkosKernels_INST_COMPLEX_DOUBLE:BOOL=ON
-D KokkosKernels_INST_OFFSET_SIZE_T:BOOL=ON
-D KokkosKernels_INST_OFFSET_INT:BOOL=ON
-D KokkosKernels_INST_ORDINAL_INT:BOOL=ON
-D KokkosKernels_INST_LAYOUTLEFT:BOOL=ON
-D KokkosKernels_INST_LAYOUTRIGHT:BOOL=ON
-D KokkosKernels_INST_LAYOUTSTRIDE:BOOL=ON
-D KokkosKernels_INST_MEMSPACE_CUDAUVMSPACE=ON
-D KokkosKernels_ENABLE_TESTS:BOOL=ON
-D KokkosKernels_TEST_ETI_ONLY:BOOL=ON
-D KokkosKernels_ENABLE_EXAMPLES:BOOL=OFF
-D KokkosKernels_ENABLE_BENCHMARK:BOOL=OFF
~/work/Kokkos/kokkos-kernels
make -j16
+- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
The kk compilation worked fine (with the change present in this PR) and the following 3 tests passed:
./blas/unit_test/KokkosKernels_blas_serial --gtest_filter=serial.syr_*
./blas/unit_test/KokkosKernels_blas_openmp --gtest_filter=openmp.syr_*
./blas/unit_test/KokkosKernels_blas_cuda --gtest_filter=Cuda.syr_*