Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ger: adding documentation stubs in apidocs #1822

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented May 9, 2023

Really not much to say beyond the fact that we forgot to do it while adding the ger function...

@lucbv lucbv requested review from e10harvey and eeprude May 9, 2023 14:12
@lucbv lucbv self-assigned this May 9, 2023
Copy link
Contributor

@eeprude eeprude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know about this, Luc. Thanks for adding it. I will add documentation for the next syr() and syr2() BLAS2 routines.

@lucbv
Copy link
Contributor Author

lucbv commented May 9, 2023

No worries, I was not too aware of the documentation procedure until recently myself!
Let us wait for @e10harvey to look at this and if he likes it we can just merge, this should be a fairly lightweight procedure : )

Copy link
Contributor

@e10harvey e10harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@e10harvey e10harvey merged commit 7c9e7b4 into kokkos:develop May 9, 2023
@lucbv lucbv deleted the ger_doc branch May 22, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants