Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for complex data types in MDF #1776

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

tmranse
Copy link
Contributor

@tmranse tmranse commented Apr 5, 2023

@lucbv

Adds distinction between scalar_type and it's magnitude type for support of non-arithmetic types e.g. Kokkos::complex . Also skips verbose prints on non-arithmetics.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv lucbv self-requested a review April 5, 2023 23:36
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use the simpler approach to define values_mag_type if you don't mind, I think it makes the code a bit easier to read.

sparse/impl/KokkosSparse_mdf_impl.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Apr 7, 2023
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Apr 7, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10 to start: Total Wait = 3603

  • Other jobs have been previously started - We must stop them...
  • Terminating Build 480 of Jenkins job KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight on Jenkins server at https://jenkins-son.sandia.gov

@tmranse
Copy link
Contributor Author

tmranse commented Apr 11, 2023

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10 to start: Total Wait = 3603

  • Other jobs have been previously started - We must stop them...
  • Terminating Build 480 of Jenkins job KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight on Jenkins server at https://jenkins-son.sandia.gov

@lucbv looks like the job timed out -- is there a way to restart it? or is this a real failure?

@lucbv
Copy link
Contributor

lucbv commented Apr 11, 2023

Sure, let me add the flag

@lucbv lucbv added the AT: RETEST Have this PR retested. label Apr 11, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 495
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

  • Build Num: 100
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 130
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 400
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 361
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 450
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 503
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 304
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 299
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 302
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (tmranse/kokkos-kernels)
  • Branch: mdfComplex
  • SHA: 51ac816
  • Mode: TEST_REPO

Pull Request Author: tmranse

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 495
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

  • Build Num: 100
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 130
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 400
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 361
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 450
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 503
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 304
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 299
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 302
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH mdfComplex
KOKKOSKERNELS_SOURCE_REPO https://github.com/tmranse/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 51ac816
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f3574e
PR_LABELS AT: RETEST
PULLREQUESTNUM 1776
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin kokkos-devops-admin removed the AT: RETEST Have this PR retested. label Apr 12, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@tmranse
Copy link
Contributor Author

tmranse commented Apr 12, 2023

Sure, let me add the flag

Great thanks, that seems to have done it. Feel free to merge on my behalf if you approve.

@lucbv lucbv merged commit 0a95fff into kokkos:develop Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants