Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop obsolete workaround #ifdef KOKKOS_IF_ON_HOST #1720

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Drop obsolete workaround #ifdef KOKKOS_IF_ON_HOST #1720

merged 1 commit into from
Mar 7, 2023

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 7, 2023

KOKKOS_IF_ON_{HOST,DEVICE} macros are always defined since Kokkos release 3.6 and current develop does not even build any more against Kokkos 3.7

@dalg24
Drop obsolete workaround checking whether KOKKOS_IF_ON_{HOST,DEVICE} …
d9df4fd 
…macros are defined

This is always true from Kokkos release 3.6 and current develop does not
even build any more against Kokkos 3.7
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Mar 7, 2023
lucbv
lucbv approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thanks for the clean-up

@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Mar 7, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 370
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 375
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 17
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 288
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 251
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 338
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 390
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 302
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 197
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 195
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 192
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)
  • Branch: drop_pre_kokkos_36_workaround
  • SHA: d9df4fd
  • Mode: TEST_REPO

Pull Request Author: dalg24

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 370
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 375
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 17
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 288
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 251
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 338
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 390
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 302
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 197
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 195
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 192
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA d9df4fd
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA e5c8da8
PR_LABELS
PULLREQUESTNUM 1720
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit 0481552 into kokkos:develop Mar 7, 2023
@dalg24 dalg24 deleted the drop_pre_kokkos_36_workaround branch March 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @kokkos-devops-admin @lucbv