Fix kk_generate_diagonally_dominant_sparse_matrix hang #1689

brian-kelley · 2023-02-17T23:53:15Z

Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present.

jgfouca · 2023-02-18T00:18:59Z

I tested this change and it does indeed fix the hang. One question, a low bandwidth will result in a random CSR with way fewer nnz values than the user requested. Is it OK to give them back something that different than what they requested?

What do you think of this patch?

--- a/sparse/src/KokkosSparse_IOUtils.hpp
+++ b/sparse/src/KokkosSparse_IOUtils.hpp
@@ -122,6 +122,7 @@ void kk_diagonally_dominant_sparseMatrix_generate(
   // Set a hard limit to the actual entries in any one row, so that the
   // loop to find a column not already taken will terminate quickly.
   OrdinalType max_elements_per_row = 0.7 * bandwidth;
+  const auto user_req_nnz = nnz;
   srand(13721);
   rowPtr[0] = 0;
   for (int row = 0; row < nrows; row++) {
@@ -138,6 +139,7 @@ void kk_diagonally_dominant_sparseMatrix_generate(
       rowPtr[row + 1] = rowPtr[row] + 1;  // at least one nonzero in the row
   }
   nnz    = rowPtr[nrows];
+  KK_REQUIRE_MSG(nnz >= user_req_nnz, "bandwidth was too low to provide desired nnz");

jgfouca

Add easy error check for bandwidth low enough to inhibit user's requested nnz.

kokkos-devops-admin · 2023-02-18T02:44:33Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

kokkos-devops-admin · 2023-02-18T03:08:44Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 320
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 326
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 240
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 239
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 202
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 289
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 339
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 259
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 154
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 152
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 148
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`52a3918`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6d73c14`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (brian-kelley/kokkos-kernels)

Pull Request Author: brian-kelley

kokkos-devops-admin · 2023-02-18T04:48:27Z

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

kokkos-devops-admin · 2023-02-18T06:21:49Z

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CLANG13CUDA10 to start: Total Wait = 3603

Other jobs have been previously started - We must stop them...
Terminating Build 322 of Jenkins job KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930 on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 328 of Jenkins job KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 242 of Jenkins job KokkosKernels_PullRequest_GCC1020 on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 241 of Jenkins job KokkosKernels_PullRequest_GCC1020_Light_LayoutRight on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 204 of Jenkins job KokkosKernels_PullRequest_Tpls_GCC1020 on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 291 of Jenkins job KokkosKernels_PullRequest_Tpls_INTEL19 on Jenkins server at https://jenkins-son.sandia.gov
Terminating Build 341 of Jenkins job KokkosKernels_PullRequest_CLANG1001 on Jenkins server at https://jenkins-son.sandia.gov

Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present.

If bandwidth is too small for the requested nnz and row_size_variance, error out with a detailed message.

brian-kelley · 2023-03-16T23:43:36Z

@jgfouca I made the change you suggested. if the bandwidth is too small for the max possible entries per row
(nnz/nrows + 0.5 * row_size_variance) then it will print a detailed message and then throw.

kokkos-devops-admin · 2023-03-17T02:00:10Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

kokkos-devops-admin · 2023-03-17T02:38:16Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 388
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

Build Num: 2
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 29
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 300
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 263
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 350
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 402
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 204
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 201
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 203
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (brian-kelley/kokkos-kernels)

Pull Request Author: brian-kelley

kokkos-devops-admin · 2023-03-17T04:37:11Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 388
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

Build Num: 2
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 29
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 300
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 263
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 350
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 402
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 204
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 201
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 203
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	FixRandomMatrixCheck
KOKKOSKERNELS_SOURCE_REPO	https://github.com/brian-kelley/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`acf6a15`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`ff097ec`
PR_LABELS
PULLREQUESTNUM	1689
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2023-03-17T04:37:28Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

kokkos-devops-admin · 2023-03-17T04:37:34Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

lucbv

Looks fine to me.

lucbv · 2023-03-17T15:45:32Z

@jgfouca can you have a quick look at this PR

jgfouca

Thanks!

kokkos-devops-admin · 2023-03-18T08:25:07Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jgfouca lucbv ]!

kokkos-devops-admin · 2023-03-18T08:25:14Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

* Fix kk_generate_diagonally_dominant_sparse_matrix hang Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present. * Diag-dominant matrix generator: error if bandwidth too small If bandwidth is too small for the requested nnz and row_size_variance, error out with a detailed message.

* Fix kk_generate_diagonally_dominant_sparse_matrix hang Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present. * Diag-dominant matrix generator: error if bandwidth too small If bandwidth is too small for the requested nnz and row_size_variance, error out with a detailed message. (cherry picked from commit 664bfc4)

ndellingwood · 2023-03-28T17:04:11Z

Cherry-picked to release-candidate-4.0.01 SHA 288beb6

* Fix kk_generate_diagonally_dominant_sparse_matrix hang Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present. * Diag-dominant matrix generator: error if bandwidth too small If bandwidth is too small for the requested nnz and row_size_variance, error out with a detailed message. (cherry picked from commit 664bfc4)

brian-kelley requested a review from jgfouca February 17, 2023 23:53

brian-kelley self-assigned this Feb 17, 2023

jgfouca approved these changes Feb 17, 2023

View reviewed changes

jgfouca requested changes Feb 18, 2023

View reviewed changes

brian-kelley added 2 commits March 16, 2023 14:53

Fix kk_generate_diagonally_dominant_sparse_matrix hang

f6de73e

Use bandwidth to cap the max entries per row, so that the row-filling loop doesn't run forever looking for a column that isn't already present.

Diag-dominant matrix generator: error if bandwidth too small

acf6a15

If bandwidth is too small for the requested nnz and row_size_variance, error out with a detailed message.

brian-kelley force-pushed the FixRandomMatrixCheck branch from 52a3918 to acf6a15 Compare March 16, 2023 22:37

brian-kelley requested a review from jgfouca March 16, 2023 23:42

lucbv approved these changes Mar 17, 2023

View reviewed changes

jgfouca approved these changes Mar 17, 2023

View reviewed changes

brian-kelley merged commit 664bfc4 into kokkos:develop Mar 18, 2023

brian-kelley deleted the FixRandomMatrixCheck branch March 18, 2023 17:49

Fix kk_generate_diagonally_dominant_sparse_matrix hang #1689

Fix kk_generate_diagonally_dominant_sparse_matrix hang #1689

Conversation

brian-kelley commented Feb 17, 2023

jgfouca commented Feb 18, 2023

jgfouca left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Feb 18, 2023

kokkos-devops-admin commented Feb 18, 2023

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Feb 18, 2023

kokkos-devops-admin commented Feb 18, 2023

brian-kelley commented Mar 16, 2023

kokkos-devops-admin commented Mar 17, 2023

kokkos-devops-admin commented Mar 17, 2023

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Mar 17, 2023