Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Kokkos::View::{R->r}ank #1679

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Prefer Kokkos::View::{R->r}ank #1679

merged 1 commit into from
Feb 9, 2023

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Feb 9, 2023

View::Rank is not documented and may get deprecated (see kokkos/kokkos#5870)
To be on the safe side, avoid using it.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv lucbv added Cleanup Code maintenance that isn't a bugfix or new feature AT: PRE-TEST INSPECTED Mark this PR as approved for testing. labels Feb 9, 2023
lucbv
lucbv approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with this change, we will advertise it at our next developer meeting to let everyone know about it.

@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 9, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 290
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 297
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 211
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 210
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 173
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 260
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 310
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 230
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 125
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 123
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 119
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)
  • Branch: view_rank
  • SHA: a05f21e
  • Mode: TEST_REPO

Pull Request Author: dalg24

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 290
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 297
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 211
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 210
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 173
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 260
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 310
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 230
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 125
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 123
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 119
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH view_rank
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA a05f21e
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA aac450b
PR_LABELS Cleanup
PULLREQUESTNUM 1679
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit c2486ab into kokkos:develop Feb 9, 2023
@dalg24 dalg24 deleted the view_rank branch February 9, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

@kliegeois kliegeois Awaiting requested review from kliegeois

@e10harvey e10harvey Awaiting requested review from e10harvey

Assignees

@dalg24 dalg24

Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @kokkos-devops-admin @lucbv