Kokkos moves ALL_t out of Impl namespace #1658

lucbv · 2023-01-31T00:33:32Z

Small PR to align our code with the recently deprecated call to Kokkos::Impl::ALL_t replaced with Kokkos::ALL_t.
This will PR shall not be merged until the release-candidate for Kokkos Kernels 4.0 is issued!

…LL_t

I suspect an invisible character was added on the modified line by the author's text editor... In any case this version now compiles fine.

kokkos-devops-admin · 2023-01-31T02:29:21Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

ndellingwood · 2023-01-31T02:44:08Z

Thanks @lucbv ! I'll give an approval after merge of #1657 and the release-candidate-4.0.0 branch is created, like you suggest.

The deprecated -Werror in the osx-ci serial relwithdebinfo build seems to be coming from Kokkos itself, I thought kokkos/kokkos#5818 was supposed to resolve?

 /Users/runner/work/kokkos-kernels/kokkos-kernels/kokkos/core/src/impl/Kokkos_ViewMapping.hpp:568:52: error: 'ALL_t' is deprecated: Use Kokkos::ALL_t instead! [-Werror,-Wdeprecated-declarations]
             const ViewDimension<DimArgs...>& dim, ALL_t, Args... args) const {
                                                   ^
/Users/runner/work/kokkos-kernels/kokkos-kernels/kokkos/core/src/impl/Kokkos_ViewMapping.hpp:303:13: note: 'ALL_t' has been explicitly marked deprecated here
using ALL_t KOKKOS_DEPRECATED_WITH_COMMENT("Use Kokkos::ALL_t instead!") =
            ^
/Users/runner/work/kokkos-kernels/kokkos-kernels/kokkos/core/src/Kokkos_Macros.hpp:583:51: note: expanded from macro 'KOKKOS_DEPRECATED_WITH_COMMENT'
#define KOKKOS_DEPRECATED_WITH_COMMENT(comment) [[deprecated(comment)]]
                                                  ^
1 error generated.
make[2]: *** [core/src/CMakeFiles/kokkoscore.dir/impl/Kokkos_Core.cpp.o] Error 1

kokkos-devops-admin · 2023-01-31T02:46:44Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 238
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 245
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 159
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 158
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 121
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 208
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 258
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 179
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 74
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 72
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 72
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (lucbv/kokkos-kernels)

Pull Request Author: lucbv

kokkos-devops-admin · 2023-01-31T05:25:30Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 238
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 245
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 159
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 158
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 121
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 208
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 258
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 179
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 74
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 72
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 72
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`6c5744f`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2023-01-31T05:25:47Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

kokkos-devops-admin · 2023-01-31T05:25:53Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

This will eliminate some of the build warning that we currently see in our CI builds of Kokkos Core.

kokkos-devops-admin · 2023-01-31T15:49:29Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

kokkos-devops-admin · 2023-01-31T15:57:46Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 239
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 246
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 160
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 159
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 122
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 209
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 259
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 180
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 75
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 73
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 73
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (lucbv/kokkos-kernels)

Pull Request Author: lucbv

kokkos-devops-admin · 2023-01-31T18:20:26Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Build Num: 239
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Build Num: 246
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Build Num: 160
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Build Num: 159
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Build Num: 122
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Build Num: 209
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 259
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Build Num: 180
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Build Num: 75
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Build Num: 73
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Build Num: 73
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	kokkos_deprecate_ALL_t
KOKKOSKERNELS_SOURCE_REPO	https://github.com/lucbv/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`d2f273c`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`f353706`
PR_LABELS	Cleanup
PULLREQUESTNUM	1658
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2023-01-31T18:20:44Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey ]!

kokkos-devops-admin · 2023-01-31T18:20:50Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

lucbv added 3 commits January 30, 2023 17:26

Fixing deprecated usage of Kokkos::Impl::ALL_t in favore of Kokkos::A…

11be16b

…LL_t

Benchmarks: for some reason the current version fails to build

215c6be

I suspect an invisible character was added on the modified line by the author's text editor... In any case this version now compiles fine.

Applying clang-format

6c5744f

lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Jan 31, 2023

lucbv requested review from ndellingwood and e10harvey January 31, 2023 00:33

lucbv self-assigned this Jan 31, 2023

osx-ci: adding option to disable deprecated_code_4 in Kokkos

d2f273c

This will eliminate some of the build warning that we currently see in our CI builds of Kokkos Core.

e10harvey approved these changes Jan 31, 2023

View reviewed changes

lucbv merged commit 78833d6 into kokkos:develop Jan 31, 2023

lucbv deleted the kokkos_deprecate_ALL_t branch January 31, 2023 18:20

Kokkos moves ALL_t out of Impl namespace #1658

Kokkos moves ALL_t out of Impl namespace #1658

Conversation

lucbv commented Jan 31, 2023

kokkos-devops-admin commented Jan 31, 2023

ndellingwood commented Jan 31, 2023

kokkos-devops-admin commented Jan 31, 2023

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Jan 31, 2023

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

Jenkins Parameters

kokkos-devops-admin commented Jan 31, 2023

kokkos-devops-admin commented Jan 31, 2023

kokkos-devops-admin commented Jan 31, 2023

kokkos-devops-admin commented Jan 31, 2023

Build Information