Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop pre Kokkos 3.6 workaround #1653

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Drop pre Kokkos 3.6 workaround #1653

merged 1 commit into from
Feb 1, 2023

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Jan 25, 2023

No description provided.

@dalg24 dalg24 added the Cleanup Code maintenance that isn't a bugfix or new feature label Jan 25, 2023
lucbv
lucbv approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we do not support older versions of Kokkos Core anyway, thanks for the clean-up

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jan 25, 2023
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jan 26, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930 to start: Total Wait = 3603

  • Other jobs have been previously started - We must stop them...

@dalg24 dalg24 force-pushed the drop_pre_kokkos_36_workaround branch from b968c81 to 4ee798d Compare January 31, 2023 22:07
lucbv
lucbv approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me, thanks for the clean-up

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jan 31, 2023
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 1, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_VEGA908_ROCM520 to start: Total Wait = 3603

@lucbv lucbv added the AT: RETEST Have this PR retested. label Feb 1, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 247
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 254
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 168
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 167
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 130
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 217
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 267
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 188
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 83
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 81
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 80
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)
  • Branch: drop_pre_kokkos_36_workaround
  • SHA: 4ee798d
  • Mode: TEST_REPO

Pull Request Author: dalg24

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 247
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 254
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 168
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 167
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 130
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 217
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 267
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 188
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 83
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 81
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 80
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH drop_pre_kokkos_36_workaround
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 4ee798d
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8394531
PR_LABELS Cleanup;AT: RETEST
PULLREQUESTNUM 1653
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin kokkos-devops-admin removed the AT: RETEST Have this PR retested. label Feb 1, 2023
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit 56cdbd2 into kokkos:develop Feb 1, 2023
@dalg24 dalg24 deleted the drop_pre_kokkos_36_workaround branch February 1, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees

@dalg24 dalg24

Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @kokkos-devops-admin @lucbv