Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup messages printed at configuration time #1616

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Cleanup messages printed at configuration time #1616

merged 2 commits into from
Dec 5, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Dec 3, 2022

Two suggested improvements:

  • Since, regardless of whether KokkosKernels is build as a standalone or within Trilinos, the minimum required version of CMake is greater than 3.12, setting the CMP0074 policy to NEW is irrelevant.
  • When no TPL is enabled, print something saying so instead of having an "empty" header

Before

=======================
Kokkos Kernels ETI Types
   Devices:  <Threads,HostSpace>
   Scalars:  double
   Ordinals: int
   Offsets:  size_t
   Layouts:  LayoutLeft

Kokkos Kernels components
   COMMON:    ON
   BATCHED:   ON
   BLAS:      ON
   GRAPH:     ON
   SPARSE:    ON

Kokkos Kernels TPLs
=======================

After

=======================
Kokkos Kernels ETI Types
   Devices:  <Threads,HostSpace>
   Scalars:  double
   Ordinals: int
   Offsets:  size_t
   Layouts:  LayoutLeft

Kokkos Kernels components
   COMMON:    ON
   BATCHED:   ON
   BLAS:      ON
   GRAPH:     ON
   SPARSE:    ON

Kokkos Kernels TPLs
   (None)
=======================

dalg24 added 2 commits December 3, 2022 08:19
@dalg24
Do not bother with CMP0074
1bad2ce 
the miminum CMake version requirement is 3.16 so setting CMP0074 to NEW
is unnecessary
@dalg24
Improve message at configuration time when no TPL is enabled
841538a
@dalg24 dalg24 added the Cleanup Code maintenance that isn't a bugfix or new feature label Dec 3, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

lucbv
lucbv approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair suggestions, thanks for looking at it

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Dec 4, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Dec 4, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 179
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 187
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 140
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 139
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 102
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 189
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 238
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 124
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 18
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 18
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 25
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)
  • Branch: improve_message_no_tpls
  • SHA: 841538a
  • Mode: TEST_REPO

Pull Request Author: dalg24

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 179
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 187
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 140
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 139
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 102
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 189
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 238
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 124
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 18
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 18
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 25
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH improve_message_no_tpls
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 841538a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 77d1d2c
PR_LABELS Cleanup
PULLREQUESTNUM 1616
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit 12244a6 into kokkos:develop Dec 5, 2022
@dalg24 dalg24 deleted the improve_message_no_tpls branch December 5, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees
No one assigned
Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalg24 @kokkos-devops-admin @lucbv