Update kk_get_free_total_memory for SYCL #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
@lucbv ping |
1 similar comment
|
@lucbv ping |
lucbv
added
Cleanup
lucbv
approved these changes
Jan 23, 2023
|
@lucbv To test on Sunspot with KK/develop, we need this PR. If not other issues, could you merge this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm#6604 at least allows for querying free memory but that isn't available in most releases. This pull request updates the current implementation to allow multiple memory modules. The update closely follows the public implementation https://github.com/intel/llvm/blob/9811ef24694f8dee5c1c8b7dd43047a63f655277/sycl/plugins/level_zero/pi_level_zero.cpp#L3147-L3167.