Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the SIMD code branch if the batched size is not a multiple of the vector length #1552

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Avoid the SIMD code branch if the batched size is not a multiple of the vector length #1552

merged 1 commit into from
Sep 28, 2022

Conversation

kliegeois
Copy link
Contributor

@kliegeois kliegeois added the bug label Sep 27, 2022
@kliegeois kliegeois requested a review from lucbv September 27, 2022 21:25
@kliegeois kliegeois added the AT: RETEST Have this PR retested. label Sep 27, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 68
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 77
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 30
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 29
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 128
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 79
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 128
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 20
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (kliegeois/kokkos-kernels)
  • Branch: Fix_SPMV_SIMD_Padding
  • SHA: 3562c23
  • Mode: TEST_REPO

Pull Request Author: kliegeois

srajama1
srajama1 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@srajama1 srajama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kliegeois !

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 68
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 77
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 30
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 29
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 128
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 79
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 128
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 20
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH Fix_SPMV_SIMD_Padding
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3562c23
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA caf47dc
PR_LABELS bug;AT: RETEST
PULLREQUESTNUM 1552
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin kokkos-devops-admin removed the AT: RETEST Have this PR retested. label Sep 28, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ srajama1 ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@srajama1 srajama1 merged commit 70b4605 into kokkos:develop Sep 28, 2022
@kliegeois kliegeois deleted the Fix_SPMV_SIMD_Padding branch September 28, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajama1 srajama1 srajama1 approved these changes

@lucbv lucbv Awaiting requested review from lucbv

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kliegeois @kokkos-devops-admin @srajama1