Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INTEL19 and CUDA11 CI settings #1505

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

e10harvey
Copy link
Contributor

  • scripts/cm_test_all_sandia:

    • Add spot check options for cuda11 and intel19 on 4 rhel7 machines
    • Switch cuda11 modules from sems-archive-env to sems-env
    • Added initial source of /etc/profile.d/modules.sh for the dev queue
  • cmake:

    • Added cmake option KokkosKernels_ENABLE_PERFTESTS
      • Note: This changes all our cmake configure to, by default, disable building perf_test. The default used to be to build perf_test but the binaries were never run in PR (or nightly?) testing. In the long run, this will save many cycles.
    • Document undocumented cmake option KokkosKernels_ENABLE_TESTS_AND_PERFSUITE
  • src/sparse:

    • Fix some warnings as errors in spmv when compiling with cuda11
    • Attempted to conditionally skip spmv_mv for ARMPL PR builds

Once this merges, we can replace the INTEL18 PR test with INTEL19.

I am leaving CUDA11 disabled due to low resource availability via the dev queue.

  - Add spot check options for cuda11 and intel19 on 4 rhel7 machines
  - Switch cuda11 modules from sems-archive-env to sems-env
  - Added initial source of /etc/profile.d/modules.sh for the dev queue

cmake:
  - Added cmake option `KokkosKernels_ENABLE_PERFTESTS`
    - Note: This changes all our cmake configure to, by default, disable building `perf_test`. The default used to be to build `perf_test` but the binaries were never run in PR (or nightly?) testing. In the long run, this will save many cycles.
  - Document undocumented cmake option `KokkosKernels_ENABLE_TESTS_AND_PERFSUITE`

src/sparse:
  - Fix some warnings as errors in spmv when compiling with cuda11
  - Attempted to conditionally skip spmv_mv for ARMPL PR builds
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue with the current logic for the perf_tests?

@e10harvey
Copy link
Contributor Author

What is the issue with the current logic for the perf_tests?

The KokkosKernels_ENABLE_PERFTEST is a new CMake option that was added because the blas3 gemm perf_tests C++ code trigger an ICE in intel 19.5.

KokkosKernels_ENABLE_TESTS_AND_PERFSUITE was undocumented before this PR and only enables/disables the raja perf suite.

The only change to perf_tests/CMakeLists.txt is to wrap everything in a if(KokkosKernels_ENABLE_PERFTEST) block.

By wrapping everything in a if(KokkosKernels_ENABLE_PERFTEST) we skip building the binaries in perf_tests. Note that these binaries are not executed by cm_test_all_sandia.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 60
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 390
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 57
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 55
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 55
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1176
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 55
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (e10harvey/kokkos-kernels)
  • Branch: pr_to_cpp17
  • SHA: 3f598c0
  • Mode: TEST_REPO

Pull Request Author: e10harvey

Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating the tests.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 60
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 390
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 57
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 55
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 55
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1176
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 55
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH pr_to_cpp17
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 3f598c0
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 4f3e7d7
PR_LABELS
PULLREQUESTNUM 1505
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@e10harvey e10harvey merged commit 28b1d9b into kokkos:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants