Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move {Serial,Team,TeamVector}Scale to KokkosBlas #1448

Merged
merged 7 commits into from
Jul 3, 2022

Conversation

mzuzek
Copy link

@mzuzek mzuzek commented Jun 23, 2022

@lucbv @fnrizzi

This PR moves SerialScale, TeamScale and TeamVectorScale from KokkosBatched to KokkosBlas.

Note: Related unit test covers combines Scale and Set, so it's moved on separate PR #1455.

@mzuzek mzuzek changed the base branch from master to develop June 23, 2022 12:14
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the only discussion needed is on how we want to expose the interface to users.

src/batched/dense/KokkosBatched_Scale_Decl.hpp Outdated Show resolved Hide resolved
src/batched/dense/KokkosBatched_Scale_Decl.hpp Outdated Show resolved Hide resolved
src/batched/dense/KokkosBatched_Scale_Decl.hpp Outdated Show resolved Hide resolved
@lucbv
Copy link
Contributor

lucbv commented Jun 27, 2022

@kliegeois @e10harvey
Let me know your thoughts on these changes, thanks!

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 27, 2022
@mzuzek mzuzek force-pushed the blas-serial-scale branch from 3b01b58 to cfadc5b Compare June 28, 2022 13:19
@mzuzek mzuzek changed the title [WIP] Move {Serial,Team}Scale to KokkosBlas Move {Serial,Team,TeamVector}Scale to KokkosBlas Jun 28, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 28, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
ERROR: USER HAS COMMITED TO PR AFTER INSPECTION, INSPECTION IS INVALID! - This PR must be re-inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 28, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 28, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 277
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 270
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 1086
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 730
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 1074
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1061
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 466
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (NexGenAnalytics/kokkos-kernels)
  • Branch: blas-serial-scale
  • SHA: cfadc5b
  • Mode: TEST_REPO

Pull Request Author: MikolajZuzek

@mzuzek mzuzek force-pushed the blas-serial-scale branch from cfadc5b to 2516f92 Compare June 28, 2022 14:29
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has commited a change to the PR before testing completed. The original testing SHA = cfadc5b Does not match the current commit SHA = 2516f92. The Jenkins Jobs will be shutdown; Testing of this PR must occur again.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 277
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 270
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 1086
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 730
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 1074
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1061
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 466
  • Status: ERROR

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA cfadc5b
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 673466c
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS
Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740 # 277 (click to expand)

Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on weaver (testbed) in workspace /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
The recommended git tool is: NONE
No credentials specified
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse --resolve-git-dir /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740/kokkos-kernels/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/ppc64le/git/2.10.1/bin/git config remote.origin.url https://github.com/NexGenAnalytics/kokkos-kernels # timeout=10
Fetching upstream changes from https://github.com/NexGenAnalytics/kokkos-kernels
 > /home/projects/ppc64le/git/2.10.1/bin/git --version # timeout=10
 > git --version # 'git version 2.10.1'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/ppc64le/git/2.10.1/bin/git fetch --tags --progress -- https://github.com/NexGenAnalytics/kokkos-kernels +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse cfadc5b419e11d3d1670185c10312ae3ec484989^{commit} # timeout=10
Checking out Revision cfadc5b419e11d3d1670185c10312ae3ec484989 (detached)
 > /home/projects/ppc64le/git/2.10.1/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git checkout -f cfadc5b419e11d3d1670185c10312ae3ec484989 # timeout=10
Commit message: "Add ETI for KokkosBlas::SerialScale"
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-list --no-walk 766ae3201d889086d6ac1bcf630ed47ca15d7e3d # timeout=10
The recommended git tool is: NONE
No credentials specified
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse --resolve-git-dir /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740/kokkos/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/ppc64le/git/2.10.1/bin/git config remote.origin.url https://github.com/kokkos/kokkos.git # timeout=10
Fetching upstream changes from https://github.com/kokkos/kokkos.git
 > /home/projects/ppc64le/git/2.10.1/bin/git --version # timeout=10
 > git --version # 'git version 2.10.1'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/ppc64le/git/2.10.1/bin/git fetch --tags --progress -- https://github.com/kokkos/kokkos.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse origin/develop^{commit} # timeout=10
Checking out Revision acb34347ac67dc55c5255c1f7dac39af47e11b5f (origin/develop)
 > /home/projects/ppc64le/git/2.10.1/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git checkout -f acb34347ac67dc55c5255c1f7dac39af47e11b5f # timeout=10
Commit message: "Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads"
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-list --no-walk a793105178a9516077cdff37c07bdab2f8ba17b8 # timeout=10
[KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740] $ /bin/bash -el /tmp/jenkins15912498630778806961.sh
***Forced exclusive execution
Job <39796> is submitted to queue .
<>
<>
Running on machine: weaver
KokkosKernels Repository Status:  cfadc5b419e11d3d1670185c10312ae3ec484989 Add ETI for KokkosBlas::SerialScale

Kokkos Repository Status: acb34347ac67dc55c5255c1f7dac39af47e11b5f Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads

Going to test compilers: cuda/9.2.88
Testing compiler cuda/9.2.88
Unrecognized compiler cuda/9.2.88 when looking for Spack variants
Unrecognized compiler cuda/9.2.88 when looking for Spack variants
Unrecognized compiler cuda/9.2.88 when looking for Spack variants
Starting job cuda-9.2.88-Cuda_OpenMP-release
kokkos devices: Cuda,OpenMP
kokkos arch: Power9,Volta70
kokkos options:
kokkos cuda options: force_uvm,enable_lambda
kokkos cxxflags: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
extra_args:
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
Build was aborted
Aborted by Evan Harvey
Finished: ABORTED

Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight # 270 (click to expand)

Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on weaver (testbed) in workspace /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
The recommended git tool is: NONE
No credentials specified
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse --resolve-git-dir /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight/kokkos-kernels/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/ppc64le/git/2.10.1/bin/git config remote.origin.url https://github.com/NexGenAnalytics/kokkos-kernels # timeout=10
Fetching upstream changes from https://github.com/NexGenAnalytics/kokkos-kernels
 > /home/projects/ppc64le/git/2.10.1/bin/git --version # timeout=10
 > git --version # 'git version 2.10.1'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/ppc64le/git/2.10.1/bin/git fetch --tags --progress -- https://github.com/NexGenAnalytics/kokkos-kernels +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse cfadc5b419e11d3d1670185c10312ae3ec484989^{commit} # timeout=10
Checking out Revision cfadc5b419e11d3d1670185c10312ae3ec484989 (detached)
 > /home/projects/ppc64le/git/2.10.1/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git checkout -f cfadc5b419e11d3d1670185c10312ae3ec484989 # timeout=10
Commit message: "Add ETI for KokkosBlas::SerialScale"
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-list --no-walk 766ae3201d889086d6ac1bcf630ed47ca15d7e3d # timeout=10
The recommended git tool is: NONE
No credentials specified
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse --resolve-git-dir /home/jenkins/weaver-new/workspace/KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight/kokkos/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/ppc64le/git/2.10.1/bin/git config remote.origin.url https://github.com/kokkos/kokkos.git # timeout=10
Fetching upstream changes from https://github.com/kokkos/kokkos.git
 > /home/projects/ppc64le/git/2.10.1/bin/git --version # timeout=10
 > git --version # 'git version 2.10.1'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/ppc64le/git/2.10.1/bin/git fetch --tags --progress -- https://github.com/kokkos/kokkos.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-parse origin/develop^{commit} # timeout=10
Checking out Revision acb34347ac67dc55c5255c1f7dac39af47e11b5f (origin/develop)
 > /home/projects/ppc64le/git/2.10.1/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/ppc64le/git/2.10.1/bin/git checkout -f acb34347ac67dc55c5255c1f7dac39af47e11b5f # timeout=10
Commit message: "Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads"
 > /home/projects/ppc64le/git/2.10.1/bin/git rev-list --no-walk a793105178a9516077cdff37c07bdab2f8ba17b8 # timeout=10
[KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight] $ /bin/bash -el /tmp/jenkins16820054224795396220.sh
***Forced exclusive execution
Job <39797> is submitted to queue .
<>
<>
Running on machine: weaver
KokkosKernels Repository Status:  cfadc5b419e11d3d1670185c10312ae3ec484989 Add ETI for KokkosBlas::SerialScale

Kokkos Repository Status: acb34347ac67dc55c5255c1f7dac39af47e11b5f Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads

Going to test compilers: cuda/10.1.243
Testing compiler cuda/10.1.243
Unrecognized compiler cuda/10.1.243 when looking for Spack variants
Unrecognized compiler cuda/10.1.243 when looking for Spack variants
Unrecognized compiler cuda/10.1.243 when looking for Spack variants
Starting job cuda-10.1.243-Cuda_Serial-release
kokkos devices: Cuda,Serial
kokkos arch: Power9,Volta70
kokkos options:
kokkos cuda options: ,enable_lambda
kokkos cxxflags: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
extra_args:
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
Build was aborted
Aborted by Evan Harvey
Finished: ABORTED

Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC720 # 1086 (click to expand)

[ 91%] Linking CXX executable KokkosKernels_wiki_spmv
Scanning dependencies of target KokkosKernels_wiki_spadd
[ 91%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_spadd.dir/KokkosSparse_wiki_spadd.cpp.o
[ 91%] Built target KokkosKernels_wiki_spmv
Scanning dependencies of target KokkosKernels_wiki_spgemm
[ 91%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_spgemm.dir/KokkosSparse_wiki_spgemm.cpp.o
[ 91%] Linking CXX executable KokkosBlas3_perf_test
[ 91%] Built target KokkosBlas3_perf_test
Scanning dependencies of target KokkosKernels_wiki_crsmatrix
[ 92%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_crsmatrix.dir/KokkosSparse_wiki_crsmatrix.cpp.o
[ 93%] Linking CXX executable KokkosKernels_batched_sla_serial
[ 93%] Built target KokkosKernels_batched_sla_serial
Scanning dependencies of target KokkosKernels_wiki_gauss_seidel
[ 93%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_gauss_seidel.dir/KokkosSparse_wiki_gauss_seidel.cpp.o
[ 94%] Linking CXX executable KokkosKernels_wiki_spadd
[ 94%] Built target KokkosKernels_wiki_spadd
[ 94%] Linking CXX executable KokkosKernels_wiki_crsmatrix
Scanning dependencies of target KokkosKernels_wiki_mis2
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_mis2.dir/KokkosGraph_wiki_mis2.cpp.o
[ 95%] Built target KokkosKernels_wiki_crsmatrix
[ 95%] Linking CXX executable KokkosKernels_wiki_spgemm
Scanning dependencies of target KokkosKernels_wiki_coloring
[ 95%] Built target KokkosKernels_wiki_spgemm
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_coloring.dir/KokkosGraph_wiki_coloring.cpp.o
Scanning dependencies of target KokkosKernels_wiki_coarsening
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_coarsening.dir/KokkosGraph_wiki_coarsening.cpp.o
[ 95%] Linking CXX executable KokkosKernels_common_threads
[ 95%] Built target KokkosKernels_common_threads
Scanning dependencies of target KokkosKernels_wiki_rcm
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_rcm.dir/KokkosGraph_wiki_rcm.cpp.o
[ 95%] Linking CXX executable KokkosKernels_wiki_gauss_seidel
[ 95%] Built target KokkosKernels_wiki_gauss_seidel
Scanning dependencies of target KokkosKernels_gmres_test_real_A
[ 96%] Building CXX object example/gmres/CMakeFiles/KokkosKernels_gmres_test_real_A.dir/test_real_A.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_mis2
[ 96%] Linking CXX executable KokkosKernels_wiki_rcm
[ 96%] Built target KokkosKernels_wiki_mis2
[ 96%] Built target KokkosKernels_wiki_rcm
Scanning dependencies of target gmres_ex_real_A
[ 96%] Building CXX object example/gmres/CMakeFiles/gmres_ex_real_A.dir/ex_real_A.cpp.o
Scanning dependencies of target KokkosKernels_gmres_test_prec
[ 96%] Building CXX object example/gmres/CMakeFiles/KokkosKernels_gmres_test_prec.dir/test_prec.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_coarsening
[ 96%] Linking CXX executable KokkosKernels_blas_serial
[ 96%] Built target KokkosKernels_wiki_coarsening
Scanning dependencies of target gmres_test_cmplx_A
[ 96%] Building CXX object example/gmres/CMakeFiles/gmres_test_cmplx_A.dir/test_cmplx_A.cpp.o
[ 96%] Built target KokkosKernels_blas_serial
[ 96%] Linking CXX executable KokkosKernels_wiki_coloring
Scanning dependencies of target team_GMRES
[ 96%] Building CXX object example/batched_solve/CMakeFiles/team_GMRES.dir/team_GMRES.cpp.o
[ 96%] Built target KokkosKernels_wiki_coloring
Scanning dependencies of target static_pivoting
[ 96%] Building CXX object example/batched_solve/CMakeFiles/static_pivoting.dir/static_pivoting.cpp.o
[ 97%] Linking CXX executable KokkosKernels_blas_threads
[ 97%] Built target KokkosKernels_blas_threads
Scanning dependencies of target xpy
[ 97%] Building CXX object example/half/CMakeFiles/xpy.dir/xpy.cpp.o
[ 98%] Linking CXX executable xpy
[ 98%] Built target xpy
[ 98%] Linking CXX executable KokkosKernels_gmres_test_real_A
[ 99%] Linking CXX executable static_pivoting
[ 99%] Linking CXX executable team_GMRES
[ 99%] Built target KokkosKernels_gmres_test_real_A
[ 99%] Built target static_pivoting
[ 99%] Built target team_GMRES
[ 99%] Linking CXX executable KokkosKernels_gmres_test_prec
[ 99%] Linking CXX executable gmres_ex_real_A
[ 99%] Built target KokkosKernels_gmres_test_prec
[ 99%] Linking CXX executable gmres_test_cmplx_A
[ 99%] Built target gmres_ex_real_A
[ 99%] Built target gmres_test_cmplx_A
[ 99%] Linking CXX executable KokkosKernels_graph_threads
[ 99%] Built target KokkosKernels_graph_threads
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/threads/Test_Threads_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/serial/Test_Serial_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/all] Error 2
[ 99%] Linking CXX executable KokkosKernels_sparse_serial
[ 99%] Built target KokkosKernels_sparse_serial
[100%] Linking CXX executable KokkosKernels_sparse_threads
[100%] Built target KokkosKernels_sparse_threads
make: *** [all] Error 2
  Starting job gcc-7.2.0-OpenMP-release
kokkos devices: OpenMP
kokkos arch: SKX
kokkos options: 
kokkos cuda options: 
kokkos cxxflags: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
extra_args: 
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
Build was aborted
Aborted by Evan Harvey
Finished: ABORTED

Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC720_Light_LayoutRight # 730 (click to expand)

[ 90%] Linking CXX executable KokkosKernels_common_serial
[ 90%] Built target KokkosKernels_common_serial
Scanning dependencies of target KokkosKernels_wiki_spadd
[ 90%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_spadd.dir/KokkosSparse_wiki_spadd.cpp.o
Scanning dependencies of target KokkosKernels_wiki_spgemm
[ 90%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_spgemm.dir/KokkosSparse_wiki_spgemm.cpp.o
[ 91%] Linking CXX executable KokkosKernels_wiki_spadd
[ 91%] Built target KokkosKernels_wiki_spadd
[ 92%] Linking CXX executable KokkosKernels_wiki_spmv
Scanning dependencies of target KokkosKernels_wiki_crsmatrix
[ 92%] Built target KokkosKernels_wiki_spmv
[ 93%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_crsmatrix.dir/KokkosSparse_wiki_crsmatrix.cpp.o
[ 93%] Linking CXX executable KokkosKernels_wiki_spgemm
[ 93%] Built target KokkosKernels_wiki_spgemm
Scanning dependencies of target KokkosKernels_wiki_gauss_seidel
[ 93%] Building CXX object example/wiki/sparse/CMakeFiles/KokkosKernels_wiki_gauss_seidel.dir/KokkosSparse_wiki_gauss_seidel.cpp.o
Scanning dependencies of target KokkosKernels_wiki_mis2
[ 94%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_mis2.dir/KokkosGraph_wiki_mis2.cpp.o
[ 95%] Linking CXX executable KokkosKernels_batched_sla_serial
[ 95%] Built target KokkosKernels_batched_sla_serial
Scanning dependencies of target KokkosKernels_wiki_coloring
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_coloring.dir/KokkosGraph_wiki_coloring.cpp.o
[ 95%] Linking CXX executable KokkosKernels_common_threads
[ 95%] Linking CXX executable KokkosKernels_wiki_crsmatrix
[ 95%] Built target KokkosKernels_common_threads
[ 95%] Built target KokkosKernels_wiki_crsmatrix
Scanning dependencies of target KokkosKernels_wiki_coarsening
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_coarsening.dir/KokkosGraph_wiki_coarsening.cpp.o
Scanning dependencies of target KokkosKernels_wiki_rcm
[ 95%] Building CXX object example/wiki/graph/CMakeFiles/KokkosKernels_wiki_rcm.dir/KokkosGraph_wiki_rcm.cpp.o
[ 95%] Linking CXX executable KokkosKernels_wiki_mis2
[ 95%] Linking CXX executable KokkosKernels_wiki_gauss_seidel
[ 95%] Built target KokkosKernels_wiki_mis2
[ 95%] Built target KokkosKernels_wiki_gauss_seidel
Scanning dependencies of target KokkosKernels_gmres_test_real_A
Scanning dependencies of target gmres_ex_real_A
[ 96%] Building CXX object example/gmres/CMakeFiles/gmres_ex_real_A.dir/ex_real_A.cpp.o
[ 96%] Building CXX object example/gmres/CMakeFiles/KokkosKernels_gmres_test_real_A.dir/test_real_A.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_rcm
[ 96%] Built target KokkosKernels_wiki_rcm
[ 96%] Linking CXX executable KokkosKernels_blas_serial
Scanning dependencies of target KokkosKernels_gmres_test_prec
[ 96%] Building CXX object example/gmres/CMakeFiles/KokkosKernels_gmres_test_prec.dir/test_prec.cpp.o
[ 96%] Built target KokkosKernels_blas_serial
[ 96%] Linking CXX executable KokkosKernels_wiki_coarsening
Scanning dependencies of target gmres_test_cmplx_A
[ 96%] Building CXX object example/gmres/CMakeFiles/gmres_test_cmplx_A.dir/test_cmplx_A.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_coloring
[ 96%] Built target KokkosKernels_wiki_coarsening
[ 96%] Built target KokkosKernels_wiki_coloring
Scanning dependencies of target team_GMRES
[ 96%] Building CXX object example/batched_solve/CMakeFiles/team_GMRES.dir/team_GMRES.cpp.o
Scanning dependencies of target static_pivoting
[ 96%] Building CXX object example/batched_solve/CMakeFiles/static_pivoting.dir/static_pivoting.cpp.o
[ 97%] Linking CXX executable static_pivoting
[ 97%] Built target static_pivoting
[ 97%] Linking CXX executable team_GMRES
Scanning dependencies of target xpy
[ 97%] Building CXX object example/half/CMakeFiles/xpy.dir/xpy.cpp.o
[ 97%] Built target team_GMRES
[ 97%] Linking CXX executable KokkosKernels_gmres_test_real_A
[ 97%] Built target KokkosKernels_gmres_test_real_A
[ 98%] Linking CXX executable KokkosKernels_blas_threads
[ 98%] Built target KokkosKernels_blas_threads
[ 98%] Linking CXX executable gmres_ex_real_A
[ 98%] Built target gmres_ex_real_A
[ 98%] Linking CXX executable KokkosKernels_gmres_test_prec
[ 98%] Built target KokkosKernels_gmres_test_prec
[ 98%] Linking CXX executable gmres_test_cmplx_A
[ 98%] Built target gmres_test_cmplx_A
[ 98%] Linking CXX executable KokkosKernels_graph_threads
[ 99%] Built target KokkosKernels_graph_threads
[ 99%] Linking CXX executable xpy
[ 99%] Built target xpy
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/threads/Test_Threads_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/serial/Test_Serial_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/all] Error 2
[ 99%] Linking CXX executable KokkosKernels_sparse_serial
[ 99%] Built target KokkosKernels_sparse_serial
[100%] Linking CXX executable KokkosKernels_sparse_threads
[100%] Built target KokkosKernels_sparse_threads
make: *** [all] Error 2
  Starting job gcc-7.2.0-OpenMP-release
kokkos devices: OpenMP
kokkos arch: SKX
kokkos options: 
kokkos cuda options: 
kokkos cxxflags: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized 
extra_args:  --no-default-eti
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutRight
Build was aborted
Aborted by Evan Harvey
Finished: ABORTED

Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_GCC720 # 1074 (click to expand)

[ 96%] Linking CXX executable KokkosKernels_wiki_coarsening
[ 96%] Built target KokkosKernels_blas_openmp
[ 96%] Built target KokkosKernels_wiki_coarsening
Scanning dependencies of target KokkosKernels_gmres_test_prec
[ 96%] Building CXX object example/gmres/CMakeFiles/KokkosKernels_gmres_test_prec.dir/test_prec.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_coloring
Scanning dependencies of target gmres_test_cmplx_A
[ 96%] Building CXX object example/gmres/CMakeFiles/gmres_test_cmplx_A.dir/test_cmplx_A.cpp.o
[ 96%] Linking CXX executable KokkosKernels_wiki_rcm
[ 96%] Built target KokkosKernels_wiki_coloring
[ 96%] Built target KokkosKernels_wiki_rcm
Scanning dependencies of target team_GMRES
[ 96%] Building CXX object example/batched_solve/CMakeFiles/team_GMRES.dir/team_GMRES.cpp.o
Scanning dependencies of target static_pivoting
[ 96%] Building CXX object example/batched_solve/CMakeFiles/static_pivoting.dir/static_pivoting.cpp.o
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:49:0,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:62,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/../test_common/KokkosKernels_TestUtils.hpp:53,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/batched/dense/Test_Batched_SerialAxpy.hpp:9,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/batched/dense/Test_Batched_Dense.hpp:5,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/serial/Test_Serial_Batched_Dense.cpp:5:
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = double; AViewType = Kokkos::View, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
   KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                     ^~~~~~
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = Kokkos::complex; AViewType = Kokkos::View**, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = double; AViewType = Kokkos::View**, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:49:0,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:62,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/../test_common/KokkosKernels_TestUtils.hpp:53,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/batched/dense/Test_Batched_SerialAxpy.hpp:9,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/batched/dense/Test_Batched_Dense.hpp:5,
                 from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/unit_test/openmp/Test_OpenMP_Batched_Dense.cpp:5:
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = double; AViewType = Kokkos::View, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
   KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                     ^~~~~~
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = Kokkos::complex; AViewType = Kokkos::View**, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function static int KokkosBlas::Impl::SerialScaleImpl::invoke(ScalarType, const AViewType&) [with ScalarType = double; AViewType = Kokkos::View**, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >; bool eti_spec_avail = false] used but never defined [-Werror]
[ 97%] Linking CXX executable KokkosKernels_blas_serial
[ 97%] Built target KokkosKernels_blas_serial
Scanning dependencies of target xpy
[ 97%] Building CXX object example/half/CMakeFiles/xpy.dir/xpy.cpp.o
[ 97%] Linking CXX executable KokkosKernels_graph_serial
[ 97%] Built target KokkosKernels_graph_serial
[ 97%] Linking CXX executable KokkosKernels_gmres_test_real_A
[ 97%] Built target KokkosKernels_gmres_test_real_A
[ 98%] Linking CXX executable static_pivoting
[ 98%] Built target static_pivoting
[ 98%] Linking CXX executable team_GMRES
[ 98%] Built target team_GMRES
[ 99%] Linking CXX executable xpy
[ 99%] Built target xpy
[ 99%] Linking CXX executable gmres_ex_real_A
[ 99%] Built target gmres_ex_real_A
[ 99%] Linking CXX executable gmres_test_cmplx_A
[ 99%] Built target gmres_test_cmplx_A
[ 99%] Linking CXX executable KokkosKernels_gmres_test_prec
[ 99%] Built target KokkosKernels_gmres_test_prec
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/serial/Test_Serial_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 99%] Linking CXX executable KokkosKernels_sparse_openmp
[ 99%] Built target KokkosKernels_sparse_openmp
[100%] Linking CXX executable KokkosKernels_sparse_serial
cc1plus: all warnings being treated as errors
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_openmp.dir/openmp/Test_OpenMP_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_openmp.dir/all] Error 2
[100%] Built target KokkosKernels_sparse_serial
make: *** [all] Error 2
#######################################################
PASSED TESTS
#######################################################
#######################################################
FAILED TESTS
#######################################################
gcc-7.2.0-OpenMP_Serial-release (build failed)
#######################################################
  # Reproducer instructions:
  #   Load modules:
        source /etc/profile.d/modules.sh
        module purge
        module load cmake/3.19.3 gcc/7.2.0 openblas/0.2.20/gcc/7.2.0

$KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-devices=OpenMP,Serial --arch=SKX --compiler=/home/projects/x86-64/gcc/7.2.0/bin/g++ --cxxflags="-O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wignored-qualifiers -Wempty-body -Wclobbered -Wuninitialized " --cxxstandard="14" --ldflags="" --kokkos-path=$KOKKOS_PATH --kokkoskernels-path=$KOKKOSKERNELS_PATH --with-scalars='double,complex_double' --with-ordinals=int --with-offsets=int,size_t --with-layouts=LayoutLeft --with-tpls=blas --user-blas-path=/home/projects/x86-64-skylake/openblas/0.2.20/gcc/7.2.0/lib --user-lapack-path=/home/projects/x86-64-skylake/openblas/0.2.20/gcc/7.2.0/lib --user-blas-lib=blas --user-lapack-lib=lapack --extra-linker-flags=-lgfortran,-lm --with-options= --with-cuda-options= --no-examples

To reload modules, reconfigure, rebuild, and retest directly from this failing build do the following:

  # Move to the build directory
    cd /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_GCC720/KokkosKernels_PullRequest_Tpls_GCC720.1074/TestAll_2022-06-28_08.18.34/gcc/7.2.0/OpenMP_Serial-release
  # To reload modules
    source ./reload_modules.sh
  # To reconfigure
    ./call_generate_makefile.sh
  # To rebuild
    make -j
  # To retest
    ctest -V

#######################################################
srun: error: blake01: task 0: Exited with exit code 1
Build step 'Execute shell' marked build as failure
Finished: FAILURE

Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_INTEL18 # 1061 (click to expand)

Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on blake (Testbed skylake) in workspace /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_INTEL18
The recommended git tool is: NONE
No credentials specified
 > /home/projects/x86-64/git/2.9.4/bin/git rev-parse --resolve-git-dir /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_INTEL18/kokkos-kernels/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/x86-64/git/2.9.4/bin/git config remote.origin.url https://github.com/NexGenAnalytics/kokkos-kernels # timeout=10
Fetching upstream changes from https://github.com/NexGenAnalytics/kokkos-kernels
 > /home/projects/x86-64/git/2.9.4/bin/git --version # timeout=10
 > git --version # 'git version 2.9.4'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/x86-64/git/2.9.4/bin/git fetch --tags --progress -- https://github.com/NexGenAnalytics/kokkos-kernels +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/x86-64/git/2.9.4/bin/git rev-parse cfadc5b419e11d3d1670185c10312ae3ec484989^{commit} # timeout=10
JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://plugins.jenkins.io/git/#remove-git-plugin-buildsbybranch-builddata-script
Checking out Revision cfadc5b419e11d3d1670185c10312ae3ec484989 (detached)
 > /home/projects/x86-64/git/2.9.4/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/x86-64/git/2.9.4/bin/git checkout -f cfadc5b419e11d3d1670185c10312ae3ec484989 # timeout=10
Commit message: "Add ETI for KokkosBlas::SerialScale"
 > /home/projects/x86-64/git/2.9.4/bin/git rev-list --no-walk 766ae3201d889086d6ac1bcf630ed47ca15d7e3d # timeout=10
The recommended git tool is: NONE
No credentials specified
 > /home/projects/x86-64/git/2.9.4/bin/git rev-parse --resolve-git-dir /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_Tpls_INTEL18/kokkos/.git # timeout=10
Fetching changes from the remote Git repository
 > /home/projects/x86-64/git/2.9.4/bin/git config remote.origin.url https://github.com/kokkos/kokkos.git # timeout=10
Fetching upstream changes from https://github.com/kokkos/kokkos.git
 > /home/projects/x86-64/git/2.9.4/bin/git --version # timeout=10
 > git --version # 'git version 2.9.4'
Setting http proxy: proxy.sandia.gov:80
 > /home/projects/x86-64/git/2.9.4/bin/git fetch --tags --progress -- https://github.com/kokkos/kokkos.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /home/projects/x86-64/git/2.9.4/bin/git rev-parse origin/develop^{commit} # timeout=10
Checking out Revision acb34347ac67dc55c5255c1f7dac39af47e11b5f (origin/develop)
 > /home/projects/x86-64/git/2.9.4/bin/git config core.sparsecheckout # timeout=10
 > /home/projects/x86-64/git/2.9.4/bin/git checkout -f acb34347ac67dc55c5255c1f7dac39af47e11b5f # timeout=10
Commit message: "Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads"
 > /home/projects/x86-64/git/2.9.4/bin/git rev-list --no-walk a793105178a9516077cdff37c07bdab2f8ba17b8 # timeout=10
[KokkosKernels_PullRequest_Tpls_INTEL18] $ /bin/bash -el /tmp/jenkins7006612037206253272.sh
Running on machine: blake
KokkosKernels Repository Status:  cfadc5b419e11d3d1670185c10312ae3ec484989 Add ETI for KokkosBlas::SerialScale

Kokkos Repository Status: acb34347ac67dc55c5255c1f7dac39af47e11b5f Merge pull request #5148 from dalg24/cleanup_exec_space_fence_overloads

Going to test compilers: intel/18.1.163
Testing compiler intel/18.1.163
Unrecognized compiler intel/18.1.163 when looking for Spack variants
Unrecognized compiler intel/18.1.163 when looking for Spack variants
Unrecognized compiler intel/18.1.163 when looking for Spack variants
Starting job intel-18.1.163-OpenMP-release
kokkos devices: OpenMP
kokkos arch: SKX
kokkos options:
kokkos cuda options:
kokkos cxxflags: -O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized
extra_args:
kokkoskernels scalars: 'double,complex_double'
kokkoskernels ordinals: int
kokkoskernels offsets: int,size_t
kokkoskernels layouts: LayoutLeft
Build was aborted
Aborted by Evan Harvey
Finished: ABORTED

Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG1001 # 466 (click to expand)

  KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                    ^
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:131:58: note: used here
    return Impl::SerialScaleImpl::invoke(alpha, A_int);
                                                         ^
3 errors generated.
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/threads/Test_Threads_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_threads.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 90%] Linking CXX executable KokkosKernels_batched_sla_threads
[ 90%] Built target KokkosKernels_batched_sla_threads
[ 90%] Linking CXX executable sparse_kk_spmv
[ 90%] Built target sparse_kk_spmv
[ 90%] Linking CXX executable KokkosKernels_common_serial
[ 90%] Built target KokkosKernels_common_serial
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/serial/Test_Serial_Batched_Dense.cpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_Dense.hpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_SerialAxpy.hpp:9:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/../test_common/KokkosKernels_TestUtils.hpp:53:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:62:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:49:
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function 'KokkosBlas::Impl::SerialScaleImpl, Kokkos::MemoryTraits<0> >, false>::invoke' is not defined [-Werror,-Wundefined-inline]
  KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                    ^
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:131:58: note: used here
    return Impl::SerialScaleImpl::invoke(alpha, A_int);
                                                         ^
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/serial/Test_Serial_Batched_Dense.cpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_Dense.hpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_SerialAxpy.hpp:9:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/../test_common/KokkosKernels_TestUtils.hpp:53:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:62:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:49:
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function 'KokkosBlas::Impl::SerialScaleImpl, Kokkos::View **, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >, false>::invoke' is not defined [-Werror,-Wundefined-inline]
  KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                    ^
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:131:58: note: used here
    return Impl::SerialScaleImpl::invoke(alpha, A_int);
                                                         ^
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/serial/Test_Serial_Batched_Dense.cpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_Dense.hpp:5:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/batched/dense/Test_Batched_SerialAxpy.hpp:9:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/unit_test/../test_common/KokkosKernels_TestUtils.hpp:53:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/sparse/KokkosSparse_spmv.hpp:62:
In file included from /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:49:
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/impl/KokkosBlas1_serial_scal_spec.hpp:85:37: error: inline function 'KokkosBlas::Impl::SerialScaleImpl **, Kokkos::LayoutStride, Kokkos::Device, Kokkos::MemoryTraits<0> >, false>::invoke' is not defined [-Werror,-Wundefined-inline]
  KOKKOS_INLINE_FUNCTION static int invoke(const ScalarType alpha,
                                    ^
/home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/kokkos-kernels/src/blas/KokkosBlas1_scal.hpp:131:58: note: used here
    return Impl::SerialScaleImpl::invoke(alpha, A_int);
                                                         ^
3 errors generated.
make[2]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/serial/Test_Serial_Batched_Dense.cpp.o] Error 1
make[1]: *** [unit_test/CMakeFiles/KokkosKernels_batched_dla_serial.dir/all] Error 2
[ 90%] Linking CXX executable KokkosKernels_graph_threads
[ 90%] Linking CXX executable KokkosBlas3_perf_test
[ 90%] Built target KokkosKernels_graph_threads
[ 90%] Built target KokkosBlas3_perf_test
[ 90%] Linking CXX executable KokkosKernels_common_threads
[ 90%] Built target KokkosKernels_common_threads
[ 91%] Linking CXX executable KokkosKernels_graph_serial
[ 91%] Built target KokkosKernels_graph_serial
[ 91%] Linking CXX executable KokkosKernels_blas_serial
[ 91%] Built target KokkosKernels_blas_serial
[ 92%] Linking CXX executable KokkosKernels_blas_threads
[ 92%] Built target KokkosKernels_blas_threads
[ 92%] Linking CXX executable KokkosKernels_sparse_serial
[ 92%] Built target KokkosKernels_sparse_serial
make: *** [all] Error 2
#######################################################
PASSED TESTS
#######################################################
#######################################################
FAILED TESTS
#######################################################
clang-10.0.1-Threads_Serial-release (build failed)
#######################################################
  # Reproducer instructions:
  #   Load modules:
        source /etc/profile.d/modules.sh
        module purge
        module load cmake/3.19.3 clang/10.0.1

$KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-devices=Threads,Serial --arch=SKX --compiler=/home/projects/x86-64/spack/opt/spack/linux-rhel7-x86_64/gcc-10.2.0/llvm-10.0.1-nldepabrxk2zcykcq7rlky5sr53hnm63/bin/clang++ --cxxflags="-O3 -Wall -Wunused-parameter -Wshadow -pedantic -Werror -Wsign-compare -Wtype-limits -Wuninitialized " --cxxstandard="14" --ldflags="" --kokkos-path=$KOKKOS_PATH --kokkoskernels-path=$KOKKOSKERNELS_PATH --with-scalars='double,complex_double' --with-ordinals=int --with-offsets=int,size_t --with-layouts=LayoutLeft --with-tpls= --with-options= --with-cuda-options= --no-examples

To reload modules, reconfigure, rebuild, and retest directly from this failing build do the following:

  # Move to the build directory
    cd /home/jenkins/blake-new/workspace/KokkosKernels_PullRequest_CLANG1001/KokkosKernels_PullRequest_CLANG1001.466/TestAll_2022-06-28_08.18.56/clang/10.0.1/Threads_Serial-release
  # To reload modules
    source ./reload_modules.sh
  # To reconfigure
    ./call_generate_makefile.sh
  # To rebuild
    make -j
  # To retest
    ctest -V

#######################################################
srun: error: blake03: task 0: Exited with exit code 1
Build step 'Execute shell' marked build as failure
Finished: FAILURE

@lucbv
Copy link
Contributor

lucbv commented Jun 28, 2022

@MikolajZuzek there should not be any ETI done for the device level functions because of relocatable device code constraints.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@mzuzek
Copy link
Author

mzuzek commented Jun 28, 2022

@lucbv Thank you for the review!

I've rebased on develop, fixed deprecation errors and moved top interfaces to single KokkosBlas1_scal.hpp header.

I've added ETI for SerialScale (then noticed #1097). I'm not sure if it's possible to have ETI for team routines as it'd require TeamPolicy member type instantiation or workaround. Also, serial routines called within batched context get views with Kokkos::LayoutStride that is not normally instantiated by ETI (weirdly enough, lot of tests check KOKKOSKERNELS_INST_LAYOUTSTRIDE option, but it doesn't seem to be defined in KokkosKernels_config.h...), which can lead to missing implementation in ETI_ONLY=ON builds (with no ETI in batched, all implementations are always available). Let me know if I should skip ETI for serial routines we move from KokkosBatched to KokkosBlas or if I should ignore ETI_ONLY and make non-ETI implementations always available.

@mzuzek
Copy link
Author

mzuzek commented Jun 28, 2022

@MikolajZuzek there should not be any ETI done for the device level functions because of relocatable device code constraints.

Got it, thanks!

@mzuzek mzuzek force-pushed the blas-serial-scale branch from 2516f92 to 95a1fae Compare June 28, 2022 14:49
@mzuzek
Copy link
Author

mzuzek commented Jun 28, 2022

@lucbv @vqd8a

As we move TeamScale from KokkosBatched to KokkosBlas, what should happen to KokkosBlas::Experimental::scal() - it's existing "twin" implementation ?

They differ in that batched routine performs X *= α while blas one performs R = α * X, so maybe they can live side by side in KokkosBlas1_scal.hpp as in-place and not-in-place variants of team scal ?

@lucbv
Copy link
Contributor

lucbv commented Jun 28, 2022

@MikolajZuzek
I would lean toward using the X *= alpha as this is the documented behavior of BLAS see here

@vqd8a
Copy link
Contributor

vqd8a commented Jun 28, 2022

@MikolajZuzek @lucbv Can we keep both in-place and not-in-place variants for some time? I believe Adelus is using not-in-place right now. Although it can be changed to use in-place in Adelus, I need to double-check. Thanks.

@mzuzek mzuzek marked this pull request as ready for review June 28, 2022 18:58
@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 28, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@mzuzek mzuzek force-pushed the blas-serial-scale branch from 95a1fae to 33495ab Compare June 30, 2022 10:21
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@mzuzek mzuzek force-pushed the blas-serial-scale branch from 33495ab to 5bec42c Compare June 30, 2022 10:27
@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 30, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jun 30, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 285
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 278
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 1094
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 738
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 1082
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1069
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 474
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (NexGenAnalytics/kokkos-kernels)
  • Branch: blas-serial-scale
  • SHA: 5bec42c
  • Mode: TEST_REPO

Pull Request Author: mzuzek

Copy link
Contributor

@kliegeois kliegeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me thanks!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 285
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 278
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 1094
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 738
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 1082
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 1069
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 474
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH blas-serial-scale
KOKKOSKERNELS_SOURCE_REPO https://github.com/NexGenAnalytics/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5bec42c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA d401735
PR_LABELS
PULLREQUESTNUM 1448
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ kliegeois ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

3 similar comments
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit df7cb44 into kokkos:develop Jul 3, 2022
@mzuzek
Copy link
Author

mzuzek commented Jul 6, 2022

@lucbv @kliegeois @e10harvey Thank you for your reviews !

@mzuzek
Copy link
Author

mzuzek commented Jul 6, 2022

@lucbv

I would lean toward using the X *= alpha as this is the documented behavior of BLAS see here

@vqd8a

@MikolajZuzek @lucbv Can we keep both in-place and not-in-place variants for some time? I believe Adelus is using not-in-place right now. Although it can be changed to use in-place in Adelus, I need to double-check. Thanks.

Not-in-place team scale was left intact: let me know anytime if you wish to remove or refactor it on a new PR.

@mzuzek mzuzek deleted the blas-serial-scale branch July 7, 2022 09:19
@mzuzek mzuzek mentioned this pull request Jul 21, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants