-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse utils namespace #1439
Sparse utils namespace #1439
Conversation
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
3 similar comments
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
-------- Oryginalna wiadomość --------Od: kokkos-devops-admin ***@***.***> Data: 13.06.2022 03:46 (GMT+01:00) Do: kokkos/kokkos-kernels ***@***.***> DW: Subscribed ***@***.***> Temat: Re: [kokkos/kokkos-kernels] Sparse utils namespace (PR #1439)
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
1 similar comment
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed one misspelling that was from before this PR, but the namespace change looks fine.
I guess this raises the question of whether some utils belong in a new namespace "KokkosGraph::Impl::", but the line between sparse and graph is fuzzy. It is also easier to keep "transpose_graph" and "transpose_matrix" together. I don't have a strong preference either way, but just a thought.
@@ -322,7 +322,7 @@ void run_experiment( | |||
// typedef typename lno_nnz_view_t::value_type lno_t; | |||
// typedef typename lno_view_t::value_type size_type; | |||
// typedef typename scalar_view_t::value_type scalar_t; | |||
KokkosKernels::Impl::kk_create_blockcrs_formated_point_crsmatrix( | |||
KokkosSparse::Impl::kk_create_blockcrs_formated_point_crsmatrix( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is it too late to fix formated -> formatted?
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]! |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
5 similar comments
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
@@ -63,6 +63,7 @@ using namespace KokkosKernels; | |||
using namespace KokkosKernels::Impl; | |||
using namespace KokkosKernels::Experimental; | |||
using namespace KokkosSparse; | |||
using namespace KokkosSparse::Impl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may lead to symbol conflicts at link time and then last-minute workarounds that will result in technical debt growth. Consider aliasing KokkosSparseImpl
to KsImpl
and KokkosKernelsImpl to
KkImpl` instead.
row_map_view_t, cols_view_t, values_view_t, row_map_view_t, | ||
host_execution_space>(nrows, nrows, row_mapM, entriesM, | ||
valuesM, row_map, entries, values); | ||
KokkosSparse::Impl::transpose_matrix< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - maybe just remove using KokkosSparse::Impl
above or switch to KsI::transpose_matrix
.
t_xadj); | ||
KokkosKernels::Impl::kk_exclusive_parallel_prefix_sum<out_row_view_t, | ||
MyExecSpace>( | ||
num_cols + 1, t_xadj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add comment +1 for...
@@ -715,7 +719,8 @@ void kk_create_reverse_map( | |||
|
|||
// kk_inclusive_parallel_prefix_sum<reverse_array_type, | |||
// MyExecSpace>(tmp_reverse_size + 1, tmp_color_xadj); | |||
kk_exclusive_parallel_prefix_sum<reverse_array_type, MyExecSpace>( | |||
KokkosKernels::Impl::kk_exclusive_parallel_prefix_sum<reverse_array_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as above. Remove using KokkosKernels::Impl
or switch to KkI::Impl
?
@@ -715,7 +719,8 @@ void kk_create_reverse_map( | |||
|
|||
// kk_inclusive_parallel_prefix_sum<reverse_array_type, | |||
// MyExecSpace>(tmp_reverse_size + 1, tmp_color_xadj); | |||
kk_exclusive_parallel_prefix_sum<reverse_array_type, MyExecSpace>( | |||
KokkosKernels::Impl::kk_exclusive_parallel_prefix_sum<reverse_array_type, | |||
MyExecSpace>( | |||
tmp_reverse_size + 1, tmp_color_xadj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above + 1 for
...
|
||
} | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay : )
out_rowmap); | ||
KokkosKernels::Impl::kk_exclusive_parallel_prefix_sum<out_row_map_view_t, | ||
exec_space>(nr + 1, | ||
out_rowmap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1 again
|
||
namespace KokkosKernels { | ||
|
||
enum [[deprecated]] SparseMatrixFormat{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@@ -212,7 +213,7 @@ void test_block_gauss_seidel_rank1(lno_t numRows, size_type nnz, | |||
// this makes consecutive 5 rows to have same columns. | |||
// it will add scalar 0's for those entries that does not exists. | |||
// the result is still a point crs matrix. | |||
KokkosKernels::Impl::kk_create_blockcrs_formated_point_crsmatrix( | |||
KokkosSparse::Impl::kk_create_blockcrs_formated_point_crsmatrix( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try using your IDE's refactor feature to easily fix the formated
typo Brian found.
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
3 similar comments
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
878f849
to
35e2f62
Compare
Using namespace alias is preferable to importing the content of namespaces since it avoids potential clashes. Of course using fully specified function names is also fine. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - Timed out waiting for ALL builds to complete: Total Wait = 21660; Max Timeout = 21600 |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740 # 300 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight # 293 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC720 # 1109 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC720_Light_LayoutRight # 753 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_GCC720 # 1097 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_INTEL18 # 1084 (click to expand)
Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG1001 # 489 (click to expand)
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Compatibility update for kokkos/kokkos-kernels#1439
Just making a namespace change for consistency and deprecating the old struct in the previous namespace.