Address #1409 #1410

kliegeois · 2022-05-12T22:01:33Z

Solve points 4 and 5 of the issue #1409.

I tried the branch on Weaver and on my workstation.

format

kokkos-devops-admin · 2022-05-12T22:05:06Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

kokkos-devops-admin · 2022-05-12T22:05:08Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

kokkos-devops-admin · 2022-05-12T22:08:58Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Build Num: 201
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Build Num: 194
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 1004
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 648
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 992
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 979
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 384
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (kliegeois/kokkos-kernels)

Pull Request Author: kliegeois

lucbv

This looks good, I guess the user is in charge of checking that the return value of Gesv is greated than 0 which indicates a failed factorization.

kliegeois · 2022-05-12T22:27:39Z

@lucbv well, that's sadly not as straightforward as this.
Now, we rely on Trsm and LU which currently do NOT return other value than 0.
However, it is not good to change them to do so if for example a division by zero is done during the Trsm solve for example. Why? Because the Trsm and LU implementations have to be consistent and one of the implementations (of both of them) relies on the MKL.

kliegeois · 2022-05-12T22:28:16Z

Sorry wrong button.

kokkos-devops-admin · 2022-05-12T23:59:03Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Build Num: 201
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Build Num: 194
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 1004
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 648
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 992
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 979
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 384
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	gesv_1409
KOKKOSKERNELS_SOURCE_REPO	https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`e137231`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`6272c01`
PR_LABELS	AT: RETEST
PULLREQUESTNUM	1410
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2022-05-12T23:59:21Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

kokkos-devops-admin · 2022-05-12T23:59:27Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-05-14T00:35:04Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-05-15T00:35:04Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-05-16T00:35:06Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

lucbv · 2022-05-16T14:58:41Z

@e10harvey
I'm not sure what the auto-tester is doing here, is it actually running something or stuck on some logic?

e10harvey · 2022-05-16T16:30:40Z

@lucbv: The AutoTester passed and is just noting that this PR should be merged. I updated the OSX CI checks in the develop branch merge settings to reflect the changes from #1411. So, this PR can be merged since the old CI checks without bounds checking settings have passed. Sorry for the confusing intermediate state here; you will likely see this on other PRs that do not have the changes from #1411 in their source branch yet.

lucbv · 2022-05-16T16:53:31Z

@e10harvey okay, the merge button is not "unlocked" probably waiting on the new bound check tests to be performed.
Do we need to rebase this PR on top of develop or do you have a mechanism to merge it since it passed our previous testing criteria?

e10harvey · 2022-05-16T18:03:32Z

@lucbv: Please try merging it now.

kokkos-devops-admin · 2022-05-17T00:44:46Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

Address kokkos#1409

e137231

format

kliegeois added the AT: RETEST Have this PR retested. label May 12, 2022

kliegeois requested a review from lucbv May 12, 2022 22:01

lucbv approved these changes May 12, 2022

View reviewed changes

kliegeois closed this May 12, 2022

kliegeois reopened this May 12, 2022

kokkos-devops-admin removed the AT: RETEST Have this PR retested. label May 12, 2022

lucbv merged commit 97cc8e6 into kokkos:develop May 17, 2022

Address #1409 #1410

Address #1409 #1410

Conversation

kliegeois commented May 12, 2022

kokkos-devops-admin commented May 12, 2022

kokkos-devops-admin commented May 12, 2022

kokkos-devops-admin commented May 12, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Using Repos:

lucbv left a comment

Choose a reason for hiding this comment

kliegeois commented May 12, 2022

kliegeois commented May 12, 2022

kokkos-devops-admin commented May 12, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

kokkos-devops-admin commented May 12, 2022

kokkos-devops-admin commented May 12, 2022

kokkos-devops-admin commented May 14, 2022

kokkos-devops-admin commented May 15, 2022

kokkos-devops-admin commented May 16, 2022

lucbv commented May 16, 2022

e10harvey commented May 16, 2022

lucbv commented May 16, 2022

e10harvey commented May 16, 2022

kokkos-devops-admin commented May 17, 2022