Remove volatile qualifiers in reducer join(), init(), and operator+= methods #1382

PhilMiller · 2022-04-09T00:50:43Z

Following kokkos/kokkos#4077 et seq, none of these methods need to take volatile-qualified parameters any longer

This should all be good on Kokkos develop and releases from 3.7/4.0 onwards, but this will break compatibility with Kokkos 3.6, in case that matters.

kokkos-devops-admin · 2022-04-09T00:58:16Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

PhilMiller · 2022-04-09T19:16:55Z

It probably makes sense to wait on running the PR tester on this until after the Kokkos fixes are on develop, so that we can actually see them pass.

PhilMiller · 2022-04-10T00:24:36Z

With revisions to the Kokkos PR, this shouldn't be strictly necessary, but it will still be desirable cleanup

PhilMiller · 2022-04-12T15:51:27Z

For now, Kokkos Kernels remains backwards compatible with the release branch for Kokkos 3.6. This PR would drop that compatibility.

The code here is fine, so feel free to move this forward whenever KK is ready to drop compatibility or breaks it elsewhere.

kokkos-devops-admin · 2022-05-17T21:34:10Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

PhilMiller · 2022-05-17T21:45:24Z

The clang-format failures in the examples/fenl file arise because the entire files are not properly formatted. So, it's nothing introduced in this PR.

PhilMiller · 2022-07-11T17:12:26Z

It would be nice to get this auto-tested and integrated before the 3.7 release branch

lucbv · 2022-07-11T17:25:27Z

@PhilMiller yeah, we need to fix some other issues first related to the new guards to prevent impl files from being included.

kokkos-devops-admin · 2022-07-13T18:04:06Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

PhilMiller · 2022-07-13T23:38:41Z

kokkos/kokkos#5215 will generate a bunch of deprecation warnings in KK until this gets merged.

lucbv · 2022-07-13T23:40:49Z

@PhilMiller did you merge a change in Kokkos develop that makes it generate the warning?

lucbv · 2022-07-13T23:41:30Z

Also please apply clang-format to you PR so that it passes our check, we are using clang-format 8.0.0

PhilMiller · 2022-07-13T23:44:34Z

That PR isn't merged yet, but it's expected to be before 3.7 is released.

Applying clang-format will result in a very noisy PR, because I have made some targeted changes to files that aren't already formatted. I think it's preferable to review this as is, and then make a separate PR to reformat those files (and potentially others) in full.

…meters exists

PhilMiller · 2022-07-14T17:07:53Z

Based on #1464 to treat the reformatting separately.

Reformat example/fenl files changed in #1382

lucbv

Looks good, thanks for the clean-up

kokkos-devops-admin · 2022-07-15T02:36:07Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

kokkos-devops-admin · 2022-07-15T02:38:10Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Build Num: 307
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Build Num: 300
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 1115
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 759
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 1103
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 1090
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 495
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (PhilMiller/kokkos-kernels)

Pull Request Author: PhilMiller

kokkos-devops-admin · 2022-07-15T04:14:59Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Build Num: 307
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Build Num: 300
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 1115
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 759
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 1103
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 1090
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 495
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	4952-volatile-join
KOKKOSKERNELS_SOURCE_REPO	https://github.com/PhilMiller/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`2f60e26`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`979cffa`
PR_LABELS
PULLREQUESTNUM	1382
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2022-07-15T04:15:16Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

kokkos-devops-admin · 2022-07-15T04:15:23Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-07-16T04:23:55Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-07-17T04:23:55Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

kokkos-devops-admin · 2022-07-18T04:23:57Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

PhilMiller force-pushed the 4952-volatile-join branch from 7788416 to a8fa21b Compare April 9, 2022 00:52

PhilMiller mentioned this pull request Apr 9, 2022

Changes to drop volatile lead to kokkos-kernels nightly test failures with OpenMP, Cuda backends on Volta70 kokkos/kokkos#4941

Closed

PhilMiller mentioned this pull request Apr 9, 2022

Detect join member function with volatile-qualified arguments kokkos/kokkos#4951

Merged

brian-kelley approved these changes Apr 9, 2022

View reviewed changes

PhilMiller marked this pull request as draft April 12, 2022 15:49

PhilMiller force-pushed the 4952-volatile-join branch from a8fa21b to d8b6b2d Compare May 17, 2022 21:28

PhilMiller changed the title ~~Remove join(volatile) overloads where join() taking non-volatile parameters exists~~ Remove volatile qualifiers in reducer join(), init(), and operator+= methods May 17, 2022

PhilMiller marked this pull request as ready for review May 17, 2022 21:30

PhilMiller force-pushed the 4952-volatile-join branch from 5ad0e64 to 94d8575 Compare July 11, 2022 17:06

PhilMiller force-pushed the 4952-volatile-join branch from bdcd6a8 to b813659 Compare July 13, 2022 23:22

PhilMiller added 3 commits July 13, 2022 18:44

Reformat example/fenl files changed in kokkos#1382

ee53604

Remove join(volatile) overloads where join() taking non-volatile para…

45e919c

…meters exists

Drop remaining uses of volatile in reducer join method signatures

2f60e26

PhilMiller force-pushed the 4952-volatile-join branch from b813659 to 2f60e26 Compare July 14, 2022 01:49

lucbv added a commit that referenced this pull request Jul 14, 2022

Merge pull request #1464 from PhilMiller/reformat-fenl

17d92d7

Reformat example/fenl files changed in #1382

lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jul 14, 2022

lucbv approved these changes Jul 14, 2022

View reviewed changes

kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jul 15, 2022

lucbv merged commit 3e6a759 into kokkos:develop Jul 18, 2022

PhilMiller deleted the 4952-volatile-join branch July 18, 2022 16:43

ndellingwood mentioned this pull request Aug 31, 2022

Nightly build failures: error: static assertion failed with "Reducer with a join() operator taking volatile-qualified parameters is no longer supported" #1509

Closed

Remove volatile qualifiers in reducer join(), init(), and operator+= methods #1382

Remove volatile qualifiers in reducer join(), init(), and operator+= methods #1382

Conversation

PhilMiller commented Apr 9, 2022 • edited Loading

kokkos-devops-admin commented Apr 9, 2022

PhilMiller commented Apr 9, 2022

PhilMiller commented Apr 10, 2022

PhilMiller commented Apr 12, 2022

kokkos-devops-admin commented May 17, 2022

PhilMiller commented May 17, 2022

PhilMiller commented Jul 11, 2022

lucbv commented Jul 11, 2022

kokkos-devops-admin commented Jul 13, 2022

PhilMiller commented Jul 13, 2022

lucbv commented Jul 13, 2022

lucbv commented Jul 13, 2022

PhilMiller commented Jul 13, 2022

PhilMiller commented Jul 14, 2022

lucbv left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Jul 15, 2022

kokkos-devops-admin commented Jul 15, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Using Repos:

kokkos-devops-admin commented Jul 15, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

kokkos-devops-admin commented Jul 15, 2022

kokkos-devops-admin commented Jul 15, 2022

kokkos-devops-admin commented Jul 16, 2022

kokkos-devops-admin commented Jul 17, 2022

kokkos-devops-admin commented Jul 18, 2022

PhilMiller commented Apr 9, 2022 •

edited

Loading