Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparse: Remove csc2csr copy by reference. #1375

Merged
merged 1 commit into from
Mar 28, 2022
Merged

sparse: Remove csc2csr copy by reference. #1375

merged 1 commit into from
Mar 28, 2022

Conversation

e10harvey
Copy link
Contributor

@e10harvey e10harvey commented Mar 28, 2022 •
edited
Loading

Fixes #1374.
Fixes #1373.

@e10harvey e10harvey requested review from dalg24 and lucbv March 28, 2022 15:53
@e10harvey e10harvey self-assigned this Mar 28, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@e10harvey
Copy link
Contributor Author

I am attempting to verify this fix using the sycl docker container.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

  • Build Num: 138
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 909
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 555
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 899
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 887
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 292
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (e10harvey/kokkos-kernels)
  • Branch: issue1374
  • SHA: abfc89a
  • Mode: TEST_REPO

Pull Request Author: e10harvey

@e10harvey
Copy link
Contributor Author

The build of Dockerfile.sycl failed with:

E: The repository 'https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64  Release' does not have a Release file.
E: The repository 'https://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1804/x86_64  Release' does not have a Release file.

@e10harvey e10harvey mentioned this pull request Mar 28, 2022
Closed
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

  • Build Num: 138
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 909
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 555
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 899
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 887
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 292
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH issue1374
KOKKOSKERNELS_SOURCE_REPO https://github.com/e10harvey/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA abfc89a
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 6cf17d0
PR_LABELS
PULLREQUESTNUM 1375
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ masterleinad dalg24 ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@e10harvey e10harvey merged commit 403a417 into kokkos:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@dalg24 dalg24 dalg24 approved these changes

@lucbv lucbv Awaiting requested review from lucbv

Assignees

@e10harvey e10harvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e10harvey @kokkos-devops-admin @dalg24 @masterleinad