Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check that view has const value type #1370

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Fix check that view has const value type #1370

merged 1 commit into from
Mar 24, 2022

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Mar 23, 2022

Partial fix for #1367

@dalg24
Copy link
Member Author

dalg24 commented Mar 23, 2022

You might want to add some test coverage for it.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Mar 24, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Mar 24, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

  • Build Num: 135
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 906
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 552
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 896
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 884
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 289
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)
  • Branch: fix_check_view_has_const_value_type
  • SHA: 9289d26
  • Mode: TEST_REPO

Pull Request Author: dalg24

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

  • Build Num: 135
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 906
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 552
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 896
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 884
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 289
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix_check_view_has_const_value_type
KOKKOSKERNELS_SOURCE_REPO https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9289d26
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 3f83b4b
PR_LABELS
PULLREQUESTNUM 1370
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit 045ae3a into kokkos:develop Mar 24, 2022
@dalg24 dalg24 deleted the fix_check_view_has_const_value_type branch March 25, 2022 00:21
ndellingwood pushed a commit to ndellingwood/kokkos-kernels that referenced this pull request Apr 7, 2022
@lucbv @ndellingwood
Merge pull request kokkos#1370 from dalg24/fix_check_view_has_const_v…
a7e683c 
…alue_type

Fix check that view has const value type

(cherry picked from commit 045ae3a)
@ndellingwood ndellingwood mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-kelley brian-kelley brian-kelley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dalg24 @kokkos-devops-admin @brian-kelley @lucbv