Fix bug in `spmv_mv_bsrmatrix()` for Ampere GPU arch #1315

dalg24 · 2022-02-13T03:01:49Z

Reported on Slack

kokkos-devops-admin · 2022-02-13T03:06:41Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

uhetmaniuk

Looks good.

@cwpearson FYI

lucbv

Thanks for finding and fixing this!

kokkos-devops-admin · 2022-02-14T13:54:49Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

kokkos-devops-admin · 2022-02-14T13:57:20Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Build Num: 66
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 837
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 484
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 828
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 816
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 221
Status: STARTED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (dalg24/kokkos-kernels)

Pull Request Author: dalg24

cwpearson · 2022-02-14T15:04:16Z

Thank you very much, probably slipped through after the initial tests on Perlmutter.

dalg24 · 2022-02-14T16:19:54Z

There is no point in running the CI. It did not catch the bug before and it will still not guarantee that these changes are correct. For what it is worth, the user reported on Slack that this patch worked for him.

kokkos-devops-admin · 2022-02-14T16:34:01Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Build Num: 66
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Build Num: 837
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Build Num: 484
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Build Num: 828
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Build Num: 816
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Build Num: 221
Status: PASSED

Jenkins Parameters

Parameter Name	Value
KOKKOSKERNELS_SOURCE_BRANCH	spmv_bsrmatrix_ampere_bug
KOKKOSKERNELS_SOURCE_REPO	https://github.com/dalg24/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA	`5a9b7e3`
KOKKOSKERNELS_TARGET_BRANCH	develop
KOKKOSKERNELS_TARGET_REPO	https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA	`e4529f9`
PR_LABELS	bug
PULLREQUESTNUM	1315
TEST_REPO_ALIAS	KOKKOSKERNELS

kokkos-devops-admin · 2022-02-14T16:34:18Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ uhetmaniuk lucbv ]!

kokkos-devops-admin · 2022-02-14T16:34:25Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

e10harvey · 2022-02-14T16:36:47Z

There is no point in running the CI. It did not catch the bug before and it will still not guarantee that these changes are correct. For what it is worth, the user reported on Slack that this patch worked for him.

@dalg24: Just add the AT: WIP label for PRs that do not need the CI checks and then ask @lucbv to force merge it for you.

e10harvey · 2022-02-14T16:38:18Z

@cwpearson: Why wasn't this caught via the unit-tests?

lucbv · 2022-02-14T16:41:18Z

@e10harvey we do not have Ampere GPUs available for testing so this part of the code cannot be tested at the moment.
It was developed on Perlmutter at NERSC which does have these GPUs.

kokkos/kokkos-kernels#1315

Fix typos x->X y->Y in spmv_mv_bsrmatrix for Ampere GPU arch

5a9b7e3

dalg24 added the bug label Feb 13, 2022

dalg24 requested a review from uhetmaniuk February 13, 2022 03:01

uhetmaniuk approved these changes Feb 13, 2022

View reviewed changes

lucbv approved these changes Feb 14, 2022

View reviewed changes

lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 14, 2022

kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Feb 14, 2022

lucbv merged commit 6fff4ff into kokkos:develop Feb 14, 2022

dalg24 deleted the spmv_bsrmatrix_ampere_bug branch February 14, 2022 17:03

petscbot pushed a commit to petsc/petsc that referenced this pull request Feb 15, 2022

config kokkos-kernels: upgrade to fix Ampere compile bug

cc8ed85

kokkos/kokkos-kernels#1315

kokkos-devops-admin mentioned this pull request May 20, 2024

Interface for LAPACK geqrf() #2205

Open

Fix bug in spmv_mv_bsrmatrix() for Ampere GPU arch #1315

Fix bug in spmv_mv_bsrmatrix() for Ampere GPU arch #1315

Conversation

dalg24 commented Feb 13, 2022

kokkos-devops-admin commented Feb 13, 2022

uhetmaniuk left a comment

Choose a reason for hiding this comment

lucbv left a comment

Choose a reason for hiding this comment

kokkos-devops-admin commented Feb 14, 2022

kokkos-devops-admin commented Feb 14, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

Using Repos:

cwpearson commented Feb 14, 2022

dalg24 commented Feb 14, 2022

kokkos-devops-admin commented Feb 14, 2022

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_Tpls_CUDA10_Tpls_CUDA10_LayoutRight_GCC720_Light_GCC720_GCC740

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

Jenkins Parameters

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

Jenkins Parameters

kokkos-devops-admin commented Feb 14, 2022

kokkos-devops-admin commented Feb 14, 2022

e10harvey commented Feb 14, 2022

e10harvey commented Feb 14, 2022

lucbv commented Feb 14, 2022

Fix bug in `spmv_mv_bsrmatrix()` for Ampere GPU arch #1315

Fix bug in `spmv_mv_bsrmatrix()` for Ampere GPU arch #1315