Fix out-of-sync Kokkos items #1288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzuzek
force-pushed
the
fix-sync-kokkos-items
branch
from
fe766fa to
a0e9d5b
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
See #1278 |
|
@MikolajZuzek thanks for helping with this, as mentioned by Damien this is already taken care of in #1278 let us hope the auto-tester picks up that PR for testing soon and it will resolve issues with the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dalg24 @lucbv
I got #1232 blocked by [unrelated] CI errors: it seems like KokkosKernels
developis no longer compiling with Kokkosdevelop?The commit here is aimed to resolve the errors, but essentially it's just a discussion starter - please feel free to take over and replace it with whatever you find appropriate.
Related Kokkos PRs: kokkos/kokkos#4660