Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace more occurences of Kokkos::Impl::is_view #1234

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

masterleinad
Copy link
Contributor

No description provided.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@dalg24 dalg24 added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Dec 17, 2021
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Dec 17, 2021
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

Copy link
Contributor

@srajama1 srajama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masterleinad for fixing this proactively!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740 to start: Total Wait = 3603

  • Other jobs have been previously started - We must stop them...

@masterleinad
Copy link
Contributor Author

Can we please merge this to get progress with making the nightly checks work again? Is there anything on my side to be done?

@masterleinad
Copy link
Contributor Author

Can we please also merge this to allow the nightly SYCL build to run again?

@e10harvey e10harvey added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jan 7, 2022
@kokkos-devops-admin kokkos-devops-admin removed the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Jan 7, 2022
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 81
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 80
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 738
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 385
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 729
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 717
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 122
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (masterleinad/kokkos-kernels)
  • Branch: replace_impl_is_view
  • SHA: e93e120
  • Mode: TEST_REPO

Pull Request Author: masterleinad

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 81
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 80
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 738
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 385
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 729
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 717
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 122
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH replace_impl_is_view
KOKKOSKERNELS_SOURCE_REPO https://github.com/masterleinad/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA e93e120
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 056443b
PR_LABELS
PULLREQUESTNUM 1234
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@kokkos-devops-admin
Copy link

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@e10harvey e10harvey merged commit 6baa4d7 into kokkos:develop Jan 7, 2022
@masterleinad masterleinad deleted the replace_impl_is_view branch January 11, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants