Fix SpGEMM crashing on empty rows #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
lucbv
reviewed
Dec 8, 2021
There was a problem hiding this comment.
This looks good I just want to make sure we are not missing a corner case, also @brian-kelley please look at this too.
| @@ -139,6 +139,8 @@ void spgemm_numeric(KernelHandle *handle, | |||
| "If you need this case please let kokkos-kernels developers know.\n"); | |||
| } | |||
|
|
|||
| if (m < 1 || n < 1 || k < 1) return; | |||
There was a problem hiding this comment.
I do not recall the exact interface we provide so I just want to make sure that the short cut above does not create issues for something like: C=beta*C+alpha*A*B which would fail to compute C=beta*C if k==0.
I believe that we only implement C=alpha*A*B though?
There was a problem hiding this comment.
Correct, we don't support adding to an existing C, so this check is OK.
kokkos-devops-admin
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Using Repos:
Pull Request Author: MikolajZuzek |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
brian-kelley
approved these changes
Dec 8, 2021
| @@ -139,6 +139,8 @@ void spgemm_numeric(KernelHandle *handle, | |||
| "If you need this case please let kokkos-kernels developers know.\n"); | |||
| } | |||
|
|
|||
| if (m < 1 || n < 1 || k < 1) return; | |||
There was a problem hiding this comment.
Correct, we don't support adding to an existing C, so this check is OK.
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley lucbv ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
SPGEMM_KK_LPto coverMultiCoreTag4functor in hash method on CPU;SPGEMM_KK_SPEEDto cover speed method -KokkosSPGEMM_numeric_speed();GPUTag4(SPGEMM_KK_MEMORY_SPREADTEAM) andGPUTag6(SPGEMM_KK_MEMORY_BIGSPREADTEAM)Details
Shared memory alignment
teamMember.team_shmem().get_shmem(shared_memory_size)aligns the size to 8 bytes rounding up and if this number is higher than allocation size inteam_shmem_size(), the allocation will fail returningnullptr(and crash follow-up computation). Thus we need to always align ourshared_memory_size.Empty row guard
Without proposed guards that skip empty rows,
GPUTag4andGPUTag6can crash trying to fetchentriesA/valuesAasa_col_begin_offsetin case of empty row indexes the first element of the next row and - when A has trailing empty rows - falls outside the view bounds: