Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1212 #1218

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix issue #1212 #1218

merged 1 commit into from
Dec 8, 2021

Conversation

kliegeois
Copy link
Contributor

This PR fixes the issue #1212 .

@kliegeois kliegeois added the AT: RETEST Have this PR retested. label Dec 7, 2021
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 12
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 12
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 670
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 317
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 661
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 648
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 54
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (kliegeois/kokkos-kernels)
  • Branch: kh_PR
  • SHA: 5b2b64f
  • Mode: TEST_REPO

Pull Request Author: kliegeois

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9_GCC720_Light_Tpls_GCC720_GCC740

  • Build Num: 12
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_Tpls_CUDA10_LayoutRight

  • Build Num: 12
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 670
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 317
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 661
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 648
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 54
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH kh_PR
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 5b2b64f
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 7563d1d
PR_LABELS AT: RETEST
PULLREQUESTNUM 1218
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin kokkos-devops-admin removed the AT: RETEST Have this PR retested. label Dec 8, 2021
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@kokkos-devops-admin
Copy link

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

lucbv
lucbv approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for the fix

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit c1bff5b into kokkos:develop Dec 8, 2021
srajama1
srajama1 reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@srajama1 srajama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kliegeois ! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajama1 srajama1 srajama1 left review comments

@lucbv lucbv lucbv approved these changes

@ndellingwood ndellingwood Awaiting requested review from ndellingwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kliegeois @kokkos-devops-admin @srajama1 @lucbv