using namespace should be scoped to prevent name clashes, see issue #1170 #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okkos#1170 Introducing a whole namespace in a public is dangerous due to the potential for name clashes with other libraries. Removing such usage from trmm, trsm and trtri resolves build issues observed by users in Trilinos.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
ndellingwood
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
lgtm thanks @lucbv ! I marked the removal locations in review notes of what I presume were the problematic public using statements
| @@ -58,8 +58,6 @@ | |||
| #include "KokkosBatched_Trmm_Decl.hpp" | |||
| #include "KokkosBatched_Trmm_Serial_Impl.hpp" | |||
|
|
|||
| using namespace KokkosBatched; | |||
| @@ -57,8 +57,6 @@ | |||
| #include "KokkosBatched_Trsm_Decl.hpp" | |||
| #include "KokkosBatched_Trsm_Serial_Impl.hpp" | |||
|
|
|||
| using namespace KokkosBatched; | |||
| @@ -55,14 +55,17 @@ | |||
| #include "KokkosBatched_Trtri_Decl.hpp" | |||
| #include "KokkosBatched_Trtri_Serial_Impl.hpp" | |||
|
|
|||
| using namespace KokkosBatched; | |||
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
srajama1
approved these changes
Nov 3, 2021
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood srajama1 ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
|
@lucbv I'll cherry-pick to master and put in PR with these changes |
ndellingwood
pushed a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Nov 4, 2021
using namespace should be scoped to prevent name clashes, see issue kokkos#1170 (cherry picked from commit e9496bb)
|
#1173 is cherry-pick to master |
ndellingwood
pushed a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Nov 5, 2021
using namespace should be scoped to prevent name clashes, see issue kokkos#1170 (cherry picked from commit e9496bb)
ndellingwood
added a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Nov 5, 2021
matching changes to PR kokkos#1171 see issue kokkos#1170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a whole namespace in a public is dangerous due to the potential for name clashes with other libraries.
Removing such usage from trmm, trsm and trtri resolves build issues observed by users in Trilinos, see issue #1170