Add missing $ to KOKKOS_HAS_TRILINOS in sparse_sptrsv_superlu check #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a syntax error with the changes in #1150, this change fixes it. I'll cherry-pick over to release-candidate-3.5.0 |
|
Cherry-picked to release-candidate-3.5.0, release-3.5.0 reset and resnapshot to the Trilinos PR |
e10harvey
reviewed
Oct 28, 2021
| @@ -73,7 +73,7 @@ KOKKOSKERNELS_ADD_EXECUTABLE( | |||
| SOURCES KokkosSparse_sptrsv_cholmod.cpp | |||
| ) | |||
|
|
|||
| IF(NOT KOKKOS_HAS_TRILINOS) | |||
| IF(NOT ${KOKKOS_HAS_TRILINOS}) | |||
There was a problem hiding this comment.
Is KOKKOS_HAS_TRILINOS an environment variable or a cmake variable?
There was a problem hiding this comment.
CMake variable, set here in Kokkos: https://github.com/kokkos/kokkos/blob/78f0bd57b5a8c297a6294204c70ca3826f043c4f/CMakeLists.txt#L36-L41
|
@e10harvey I had to update the branch for merge and looks like it dismissed your previous review, could you re-approve? |
lucbv
approved these changes
Oct 28, 2021
e10harvey
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PR #1150