Tpl rocblas and rocsparse #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-kelley
requested changes
Oct 26, 2021
cmake/kokkoskernels_tpls.cmake
Outdated
| @@ -1,514 +1,573 @@ | |||
| FUNCTION(kokkoskernels_append_config_line LINE) | |||
There was a problem hiding this comment.
Looks like autoformatting broke some things in this file - sometimes it inserted a space, likeKOKKOSKERNELS_${TPL_NAME}_ROOT became KOKKOSKERNELS_${TPL_NAME} _ROOT, or changed
${SOME_VAR}
to
${
SOME_VAR}
There was a problem hiding this comment.
Come to think of it, clang-format doesn't actually check the file extension or type. If you pass it a non-C++ file, it will be happy to mangle it :)
Maybe the script to format all the git added files could check for hpp/cpp file extensions ( @e10harvey )
There was a problem hiding this comment.
OK, I will look at that again, I want to add something for the rocsparse handle first so that the PR will set us up for integration of some of the TPLs in the blas and sparse kernels.
Thanks for noticing these though, I'll make sure to run clang-format and then build and test on Spock : )
lucbv
force-pushed
the
TPL_rocblas_rocsparse
branch
2 times, most recently
from
acf2802 to
7a9e541
Compare
|
@brian-kelley |
|
@e10harvey |
Hi @lucbv, https://cmake.org/cmake/help/latest/command/configure_file.html indicates that the syntax is |
|
@e10harvey thanks, I did not think about the local format de-activation, I will do that! |
lucbv
force-pushed
the
TPL_rocblas_rocsparse
branch
from
fc5d495 to
b99dd39
Compare
|
@lucbv Since the TPL logic creates a standard option named like and analogously this to cmake/Modules/FindTPLROCSPARSE.cmake: That made it easy to configure on Caraway by setting ROCBLAS_ROOT/ROCSPARSE_ROOT, as an alternative to using ROCM_PATH (I tested both ways). |
|
@brian-kelley sure, I'll look into it. Anyway I clearly have something wrong in my logic as the whole thing fails when rocblas/rocsparse are not available x) |
Adding some infrastructure in cmake and tests to enable rocBLAS and rocSPARSE and check that is compiles correctly and that simple calls to get library versions are working.
Adding similar utitlies and tests for rocSPARSE as the ones previously added for rocBLAS.
Since ROCm does not ship with these libraries by default, they should be turned OFF by default and only turned ON if the user has requested them explicitely.
Adding KokkosKernels_ROCBLAS_ROOT and KokkosKernels_ROCSPARSE_ROOT to the FindTPL modules as they are defined automatically by our TPL system and should be available to users.
lucbv
force-pushed
the
TPL_rocblas_rocsparse
branch
from
8ccbfae to
53537c9
Compare
|
@brian-kelley |
| @@ -0,0 +1,60 @@ | |||
| // Note: Luc Berger-Vergiat 10/25/21 | |||
| // Only include this test if compiling | |||
| // the cuda sparse tests and cuSPARSE | |||
There was a problem hiding this comment.
This comment should say "HIP/rocSPARSE" probably
brian-kelley
approved these changes
Oct 29, 2021
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_Tpls_GCC720_GCC740 to start: Total Wait = 3603
|
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
Using Repos:
Pull Request Author: lucbv |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL18
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_CUDA9
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for AMD device libraries: rocBLAS and rocSPARSE.
Everything configures, compiles and runs fine on Spock, there is a chance that this will fail on caraway depending on how the libraries are installed.