Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix values dimension for block sparse matrices #1147

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Fix values dimension for block sparse matrices #1147

merged 3 commits into from
Oct 25, 2021

Conversation

uhetmaniuk
Copy link
Contributor

Closes #1146

@uhetmaniuk uhetmaniuk added the bug label Oct 20, 2021
@uhetmaniuk uhetmaniuk self-assigned this Oct 20, 2021
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@uhetmaniuk uhetmaniuk changed the title Update KokkosSparse_BsrMatrix.hpp Fix values dimension for block sparse matrices Oct 20, 2021
@uhetmaniuk uhetmaniuk requested review from lucbv and srajama1 October 20, 2021 00:51
@uhetmaniuk
Copy link
Contributor Author

@cwpearson

I do not know why but I can not add you as reviewer.

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@uhetmaniuk uhetmaniuk linked an issue Oct 20, 2021 that may be closed by this pull request
values not sized properly when using graph constructor #1146
Closed
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cwpearson ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 138
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 516
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 163
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 507
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 138
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 493
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 137
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 135
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 128
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (uhetmaniuk/kokkos-kernels)
  • Branch: 1146-fix-values-size
  • SHA: 57c02d6
  • Mode: TEST_REPO

Pull Request Author: uhetmaniuk

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 138
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 516
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 163
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 507
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 138
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 493
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 137
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 135
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 128
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH 1146-fix-values-size
KOKKOSKERNELS_SOURCE_REPO https://github.com/uhetmaniuk/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 57c02d6
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA f631acb
PR_LABELS bug
PULLREQUESTNUM 1147
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cwpearson ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

lucbv
lucbv approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@lucbv lucbv merged commit 533517b into kokkos:develop Oct 25, 2021
@lucbv lucbv mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

@cwpearson cwpearson cwpearson approved these changes

@srajama1 srajama1 Awaiting requested review from srajama1

Assignees

@uhetmaniuk uhetmaniuk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

values not sized properly when using graph constructor
4 participants
@uhetmaniuk @kokkos-devops-admin @cwpearson @lucbv