Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the batched dense files to specific directories #1098

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Move the batched dense files to specific directories #1098

merged 2 commits into from
Sep 15, 2021

Conversation

kliegeois
Copy link
Contributor

This PR reorganizes the batched dense files to be located in subdirectories of the batched directories (both for src and unit_test).

The PR adds batched sparse unit tests (which are empty for now).

The cuda and serial tests passed on Weaver.

@lucbv

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@lucbv lucbv self-requested a review September 8, 2021 14:21
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

lucbv
lucbv reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes overall, this follows more closely the structure in the rest of Kokkos Kernels.
I only have one question, do we keep the top batched folder or do we remove it and name the two new folders batched_dense and batched_sparse?

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 55
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 434
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 81
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 425
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 56
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 411
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 55
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 53
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 47
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (kliegeois/kokkos-kernels)
  • Branch: batched-dense
  • SHA: 9af94b2
  • Mode: TEST_REPO

Pull Request Author: kliegeois

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 55
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 434
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 81
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 425
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 56
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 411
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 55
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 53
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 47
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH batched-dense
KOKKOSKERNELS_SOURCE_REPO https://github.com/kliegeois/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 9af94b2
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA a901b87
PR_LABELS
PULLREQUESTNUM 1098
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

2 similar comments
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

e10harvey
e10harvey approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@e10harvey e10harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kliegeois !

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

1 similar comment
@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

brian-kelley
brian-kelley approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@brian-kelley brian-kelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lucbv lucbv merged commit c8c0f21 into kokkos:develop Sep 15, 2021
@e10harvey e10harvey mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e10harvey e10harvey e10harvey approved these changes

@lucbv lucbv lucbv approved these changes

@brian-kelley brian-kelley brian-kelley approved these changes

@srajama1 srajama1 Awaiting requested review from srajama1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kliegeois @kokkos-devops-admin @brian-kelley @lucbv @e10harvey