Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test scripts: add option to disable kokkos desul atomics" #1039

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Revert "test scripts: add option to disable kokkos desul atomics" #1039

merged 1 commit into from
Jul 7, 2021

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Jul 7, 2021

Reverts #1036
This will allow us to test the new fixes in Kokkos

@lucbv lucbv requested review from ndellingwood and srajama1 July 7, 2021 15:37
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 322
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 314
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 300
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 356
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 133
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 321
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 132
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 316
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 314
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (kokkos/kokkos-kernels)
  • Branch: revert-1036-testscripts-desul
  • SHA: 374faca
  • Mode: TEST_REPO

Pull Request Author: lucbv

@srajama1
Copy link
Contributor

srajama1 commented Jul 7, 2021

Now looking at the PR, do you want to revert the whole thing? Having the option to turn it on/off is good, right? Can we just change the default?

@lucbv
Copy link
Contributor Author

lucbv commented Jul 7, 2021

Yes, I think it's fine, if the auto-tester and then the jenkins tests work fine there is not reason to keep the option.
Also I am pretty sure it will be removed from Kokkos as soon as users have tested it...
If something goes wrong we can always revert this revert.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 322
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 314
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 300
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 356
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 133
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 321
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 132
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 316
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 314
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH revert-1036-testscripts-desul
KOKKOSKERNELS_SOURCE_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 374faca
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA dea9924
PR_LABELS
PULLREQUESTNUM 1039
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@kokkos-devops-admin
Copy link

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

srajama1
srajama1 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@srajama1 srajama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok approving it.

@srajama1
Copy link
Contributor

srajama1 commented Jul 7, 2021

Thanks @lucbv !

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ srajama1 ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit ae9b047 into develop Jul 7, 2021
@lucbv lucbv deleted the revert-1036-testscripts-desul branch February 16, 2022 01:22
@kokkos-devops-admin kokkos-devops-admin mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srajama1 srajama1 srajama1 approved these changes

@ndellingwood ndellingwood Awaiting requested review from ndellingwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucbv @kokkos-devops-admin @srajama1