Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supernodal SpTrsv: fix out-of-bound error #1019

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

iyamazaki
Copy link
Contributor

This PR tries to fix the out-of-bound errors for issue #1016.

@iyamazaki iyamazaki requested a review from ndellingwood June 10, 2021 19:55
@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 302
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 294
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 280
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 336
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 113
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 301
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 112
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 296
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 294
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (iyamazaki/kokkos-kernels)
  • Branch: sptrsv-debug
  • SHA: 02f2abc
  • Mode: TEST_REPO

Pull Request Author: iyamazaki

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC720

  • Build Num: 302
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720

  • Build Num: 294
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL18

  • Build Num: 280
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light

  • Build Num: 336
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC720_Light_LayoutRight

  • Build Num: 113
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10

  • Build Num: 301
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA10_LayoutRight

  • Build Num: 112
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_CUDA9

  • Build Num: 296
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC720_GCC740

  • Build Num: 294
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH sptrsv-debug
KOKKOSKERNELS_SOURCE_REPO https://github.com/iyamazaki/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 02f2abc
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA 8f4fb10
PR_LABELS
PULLREQUESTNUM 1019
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@kokkos-devops-admin
Copy link

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks @iyamazaki !

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@ndellingwood
Copy link
Contributor

PR tests successful, merging. I'll close the issue tomor after confirming the nightly passes. Thanks @iyamazaki !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants