SpAdd doesn't merge entries correctly #685
Assignees
Labels
Comments
brian-kelley
added a commit
to brian-kelley/kokkos-kernels
that referenced
this issue
Jul 29, 2020
-remove vector/team size stuff from handle, because it only uses range policy -remove "get_max_result_nnz", should only use "get_c_nnz" now. Max is a bad name for what this is, since C always has exactly this many nonzeros, it's not an upper bound. -address kokkos#694 (don't require values to be initialized) -address kokkos#685 (produce a fully sorted and merged C even if A and/or B aren't merged) -improve testing: test matrix with zero rows per entry, and test matrix with duplicate entries
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Neither the sorted nor unsorted versions of SpAdd will merge entries if the input is unmerged (has duplicate entries in a row). It produces the correct sum, but it should be able to merge any number of duplicate entries for no performance penalty.
The text was updated successfully, but these errors were encountered: