trsv - internal compiler error with intel/19

[ndellingwood]

Reported by Mike Glass, observed on the mutrino testbed

Error message

/lscratch1/ndellin/kokkos-kernels/src/sparse/impl/KokkosSparse_trsv_spec.hpp(138) (col. 11): internal error: 04010002_12261

compilation aborted for /lscratch1/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/trsv/KokkosSparse_trsv_eti_spec_inst_Kokkos_cmplx_dbl__int_int_LayoutLeft_Serial_HostSpace.cpp (code 4)
src/CMakeFiles/kokkoskernels.dir/build.make:18062: recipe for target 'src/CMakeFiles/kokkoskernels.dir/impl/generated_specializations_cpp/trsv/KokkosSparse_trsv_eti_spec_inst_Kokkos_cmplx_dbl__int_int_LayoutLeft_Serial_HostSpace.cpp.o' failed
make[2]: *** [src/CMakeFiles/kokkoskernels.dir/impl/generated_specializations_cpp/trsv/KokkosSparse_trsv_eti_spec_inst_Kokkos_cmplx_dbl__int_int_LayoutLeft_Serial_HostSpace.cpp.o] Error 4
make[2]: *** Waiting for unfinished jobs....
/lscratch1/ndellin/kokkos-kernels/src/sparse/impl/KokkosSparse_trsv_spec.hpp(138) (col. 11): internal error: 04010002_12261

compilation aborted for /lscratch1/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/trsv/KokkosSparse_trsv_eti_spec_inst_Kokkos_cmplx_dbl__size_t_int_LayoutLeft_Serial_HostSpace.cpp (code 4)
src/CMakeFiles/kokkoskernels.dir/build.make:18254: recipe for target 'src/CMakeFiles/kokkoskernels.dir/impl/generated_specializations_cpp/trsv/KokkosSparse_trsv_eti_spec_inst_Kokkos_cmplx_dbl__size_t_int_LayoutLeft_Serial_HostSpace.cpp.o' failed

Reproducer instructions:
Clone kokkos, kokkos-kernels

module load intel/19.0.4  cmake/3.10.2
export KOKKOS_PATH=${SCRATCH}/kokkos
export KOKKOSKERNELS_PATH=${SCRATCH}/kokkos-kernels

${KOKKOSKERNELS_PATH}/cm_generate_makefile.bash --compiler=icpc --kokkos-path=${KOKKOS_PATH} --kokkoskernels-path=${KOKKOSKERNELS_PATH} --arch=KNL --with-scalars=complex_double

[ndellingwood]

Workaround PR issued #608 and Trilinos patch submitted in PR trilinos/Trilinos#6858

[ndellingwood]

PR #608 merged.

[ndellingwood]

Added intel/19.0.5 nightly test https://jenkins-son.sandia.gov/view/KokkosKernels/job/KokkosKernels_KokkosDev2_Intel19_0_5/

[ndellingwood]

For reference I should mention the issue here - internal compiler errors were occurring in the trsv routine, turned out the compiler was dying on the /= operators. Replacing calls like a /= b; with a = a / b; served as a functional workaround allowing compilation of code to complete.